[PATCH 2/3] regmap: fix regcache_reg_present() for empty cache

[PATCH 2/3] regmap: fix regcache_reg_present() for empty cache

[Ionut Nicu]

In the initial case when no reg_defaults values are
provided and no register value was added to the cache
yet, the cache_present bitmap is NULL. If this function
is invoked for any register it should return false
(i.e. the register is not cached) instead of true.

Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
---
 drivers/base/regmap/internal.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 29c8316..5308e3e 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -223,7 +223,7 @@ int regcache_set_reg_present(struct regmap *map, unsigned int reg);
 static inline bool regcache_reg_present(struct regmap *map, unsigned int reg)
 {
 	if (!map->cache_present)
-		return true;
+		return false;
 	if (reg > map->cache_present_nbits)
 		return false;
 	return map->cache_present[BIT_WORD(reg)] & BIT_MASK(reg);
-- 
1.7.1

Re: [PATCH 2/3] regmap: fix regcache_reg_present() for empty cache

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

On Fri, Aug 09, 2013 at 12:09:15PM +0200, Ionut Nicu wrote:
> In the initial case when no reg_defaults values are
> provided and no register value was added to the cache
> yet, the cache_present bitmap is NULL. If this function
> is invoked for any register it should return false
> (i.e. the register is not cached) instead of true.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]