From: walter harms <wharms@bfs.de>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Jonathan Cameron <jic23@cam.ac.uk>,
kernel-janitors@vger.kernel.org,
Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently
Date: Sat, 10 Aug 2013 19:49:46 +0200 [thread overview]
Message-ID: <52067D3A.2090505@bfs.de> (raw)
In-Reply-To: <1376148738.2083.17.camel@joe-AO722>
Am 10.08.2013 17:32, schrieb Joe Perches:
> On Sat, 2013-08-10 at 17:25 +0200, Julia Lawall wrote:
>> From: Julia Lawall <Julia.Lawall@lip6.fr>
>>
>> Because ARRAY_AND_SIZE changes the apparent arity of a function, if it is
>> used for one call to a given function, it would be better, if possible, to
>> use it for all of them.
>
> I think it'd be better to remove ARRAY_AND_SIZE instead.
>
+1
:)
re,
wh
next prev parent reply other threads:[~2013-08-10 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 15:25 [PATCH] arch/arm/mach-pxa/stargate2.c: use ARRAY_AND_SIZE consistently Julia Lawall
2013-08-10 15:32 ` Joe Perches
2013-08-10 15:38 ` Julia Lawall
2013-08-10 15:59 ` Joe Perches
2013-08-10 17:49 ` walter harms [this message]
2013-08-10 22:33 ` Dan Carpenter
2013-08-11 5:48 ` Julia Lawall
2013-08-11 7:34 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52067D3A.2090505@bfs.de \
--to=wharms@bfs.de \
--cc=Julia.Lawall@lip6.fr \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox