From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974Ab3HLIW1 (ORCPT ); Mon, 12 Aug 2013 04:22:27 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:33539 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187Ab3HLIWW (ORCPT ); Mon, 12 Aug 2013 04:22:22 -0400 Message-ID: <5208A95A.70606@kernel.org> Date: Mon, 12 Aug 2013 10:22:34 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Julia Lawall CC: Jonathan Cameron , kernel-janitors@vger.kernel.org, Eric Miao , Russell King , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: Avoid using ARRAY_AND_SIZE(e) as a function argument References: <1376239917-15594-1-git-send-email-Julia.Lawall@lip6.fr> <1376239917-15594-17-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1376239917-15594-17-git-send-email-Julia.Lawall@lip6.fr> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/13 17:51, Julia Lawall wrote: > From: Julia Lawall > > Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the > arity of the called function. > > The semantic match that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e,f; > @@ > > f(..., > - ARRAY_AND_SIZE(e) > + e,ARRAY_SIZE(e) > ,...) > // > > Signed-off-by: Julia Lawall Acked-by: Jonathan Cameron Thanks, > > --- > Not compiled. > > arch/arm/mach-pxa/stargate2.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c > index 62aea3e..adacedd 100644 > --- a/arch/arm/mach-pxa/stargate2.c > +++ b/arch/arm/mach-pxa/stargate2.c > @@ -406,7 +406,8 @@ static struct i2c_pxa_platform_data i2c_pdata = { > static void __init imote2_stargate2_init(void) > { > > - pxa2xx_mfp_config(ARRAY_AND_SIZE(sg2_im2_unified_pin_config)); > + pxa2xx_mfp_config(sg2_im2_unified_pin_config, > + ARRAY_SIZE(sg2_im2_unified_pin_config)); > > pxa_set_ffuart_info(NULL); > pxa_set_btuart_info(NULL); > @@ -604,7 +605,7 @@ static struct platform_device *imote2_devices[] = { > > static void __init imote2_init(void) > { > - pxa2xx_mfp_config(ARRAY_AND_SIZE(imote2_pin_config)); > + pxa2xx_mfp_config(imote2_pin_config, ARRAY_SIZE(imote2_pin_config)); > > imote2_stargate2_init(); > > @@ -983,13 +984,15 @@ static void __init stargate2_init(void) > prior to connecting the MFP stuff up. */ > __raw_writel(__raw_readl(MECR) & ~MECR_NOS, MECR); > > - pxa2xx_mfp_config(ARRAY_AND_SIZE(stargate2_pin_config)); > + pxa2xx_mfp_config(stargate2_pin_config, > + ARRAY_SIZE(stargate2_pin_config)); > > imote2_stargate2_init(); > > - platform_add_devices(ARRAY_AND_SIZE(stargate2_devices)); > + platform_add_devices(stargate2_devices, ARRAY_SIZE(stargate2_devices)); > > - i2c_register_board_info(0, ARRAY_AND_SIZE(stargate2_i2c_board_info)); > + i2c_register_board_info(0, stargate2_i2c_board_info, > + ARRAY_SIZE(stargate2_i2c_board_info)); > i2c_register_board_info(1, stargate2_pwr_i2c_board_info, > ARRAY_SIZE(stargate2_pwr_i2c_board_info)); > >