From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 4/4] x86/jump-label: Show where and what was wrong on errors
Date: Mon, 12 Aug 2013 07:32:08 -0700 [thread overview]
Message-ID: <5208F1E8.4050902@zytor.com> (raw)
In-Reply-To: <20130812143116.GJ27162@twins.programming.kicks-ass.net>
On 08/12/2013 07:31 AM, Peter Zijlstra wrote:
> On Wed, Aug 07, 2013 at 07:20:44PM +0200, Borislav Petkov wrote:
>> Besides, BUG can be disabled in CONFIG_EXPERT.
>
> There was some email on this subject a while ago; disabling BUG() is
> very risky and can cause all kinds of horrid. IIRC the consensus back
> then was to remove this 'feature' and have BUG always at least lock up
> the machine hard.
>
Yes, always trap but leave the metadata as optional.
-hpa
next prev parent reply other threads:[~2013-08-12 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 16:49 [PATCH 0/4] [GIT PULL][3.12] x86/jump-label: Clean ups and safety checks Steven Rostedt
2013-08-07 16:49 ` [PATCH 1/4] x86/jump-label: Use best default nops for inital jump label calls Steven Rostedt
2013-08-07 16:49 ` [PATCH 2/4] x86/jump-label: Do not bother updating nops if they are correct Steven Rostedt
2013-08-07 16:49 ` [PATCH 3/4] x86/jump-label: Add safety checks to jump label conversions Steven Rostedt
2013-08-07 16:49 ` [PATCH 4/4] x86/jump-label: Show where and what was wrong on errors Steven Rostedt
2013-08-07 17:20 ` Borislav Petkov
2013-08-07 17:33 ` Steven Rostedt
2013-08-07 17:37 ` Borislav Petkov
2013-08-07 17:46 ` Steven Rostedt
2013-08-07 17:51 ` H. Peter Anvin
2013-08-07 18:41 ` Borislav Petkov
2013-08-07 18:45 ` H. Peter Anvin
2013-08-12 14:31 ` Peter Zijlstra
2013-08-12 14:32 ` H. Peter Anvin [this message]
2013-08-12 15:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208F1E8.4050902@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox