From: David Vrabel <david.vrabel@citrix.com>
To: Yechen Li <lccycc123@gmail.com>
Cc: <xen-devel@lists.xen.org>, <dario.faggioli@citrix.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v1][RFC] drivers/xen, balloon driver numa support in kernel
Date: Mon, 12 Aug 2013 19:44:09 +0100 [thread overview]
Message-ID: <52092CF9.4050006@citrix.com> (raw)
In-Reply-To: <1376316812-30346-1-git-send-email-lccycc123@gmail.com>
On 12/08/13 15:13, Yechen Li wrote:
> This small patch adds numa support for balloon driver. Kernel version: 3.11-rc5
> It's just a RFC version, since I'm waiting for the interface of numa topology.
> The balloon driver will read arguments from xenstore: /local/domain/(id)/memory
> /target_nid, and settle the memory increase/decrease operation on specified
> p-nodeID.
Its is difficult to review an ABI change without any documentation for
the new ABI.
I would also like to see a design document explaining the overall
approach planned to be used here. It's not clear why explicitly
specifying nodes is preferable to (e.g.) the guest releasing/populating
evenly across all its nodes (this would certainly be better for the guest).
It seems like unless this is used carefully, all VMs will end up with
suboptimal memory layouts as they are repeatedly balloon up and down to
satisfy the whims of the latest VM being started etc.
David
next prev parent reply other threads:[~2013-08-12 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 14:13 [PATCH v1][RFC] drivers/xen, balloon driver numa support in kernel Yechen Li
2013-08-12 18:44 ` David Vrabel [this message]
2013-08-12 20:14 ` [Xen-devel] " Dario Faggioli
[not found] ` <1376339161.15390.281.camel@Solace>
2013-08-13 12:46 ` Konrad Rzeszutek Wilk
[not found] ` <520A2C52.3000804@citrix.com>
2013-08-13 13:18 ` Konrad Rzeszutek Wilk
2013-08-13 19:00 ` [Xen-devel] " Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52092CF9.4050006@citrix.com \
--to=david.vrabel@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=lccycc123@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox