* [PATCH][3.11] cpuset: fix the return value of cpuset_write_u64()
@ 2013-08-13 2:05 Li Zefan
2013-08-13 14:57 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2013-08-13 2:05 UTC (permalink / raw)
To: Tejun Heo; +Cc: LKML, cgroups
Writing to this file always returns -ENODEV:
# echo 1 > cpuset.memory_pressure_enabled
-bash: echo: write error: No such device
Signed-off-by: Li Zefan <lizefan@huawei.com>
Cc: <stable@vger.kernel.org> # 3.9+
---
kernel/cpuset.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 1b9c315..c602ab8 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1607,11 +1607,13 @@ static int cpuset_write_u64(struct cgroup *cgrp, struct cftype *cft, u64 val)
{
struct cpuset *cs = cgroup_cs(cgrp);
cpuset_filetype_t type = cft->private;
- int retval = -ENODEV;
+ int retval = 0;
mutex_lock(&cpuset_mutex);
- if (!is_cpuset_online(cs))
+ if (!is_cpuset_online(cs)) {
+ retval = -ENODEV;
goto out_unlock;
+ }
switch (type) {
case FILE_CPU_EXCLUSIVE:
--
1.8.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][3.11] cpuset: fix the return value of cpuset_write_u64()
2013-08-13 2:05 [PATCH][3.11] cpuset: fix the return value of cpuset_write_u64() Li Zefan
@ 2013-08-13 14:57 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2013-08-13 14:57 UTC (permalink / raw)
To: Li Zefan; +Cc: LKML, cgroups
On Tue, Aug 13, 2013 at 10:05:59AM +0800, Li Zefan wrote:
> Writing to this file always returns -ENODEV:
>
> # echo 1 > cpuset.memory_pressure_enabled
> -bash: echo: write error: No such device
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
> Cc: <stable@vger.kernel.org> # 3.9+
Applied to cgroup/for-3.11-fixes. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-13 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-13 2:05 [PATCH][3.11] cpuset: fix the return value of cpuset_write_u64() Li Zefan
2013-08-13 14:57 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox