* [PATCH 3/8] net: fec_mpc52xx_phy: use platform_{get,set}_drvdata()
@ 2013-08-12 13:24 Libo Chen
2013-08-14 3:39 ` [PATCH RESEND " Libo Chen
0 siblings, 1 reply; 2+ messages in thread
From: Libo Chen @ 2013-08-12 13:24 UTC (permalink / raw)
To: David Miller, timur; +Cc: netdev, LKML, Li Zefan
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
index 360a578..e052890 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
@@ -123,12 +123,10 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of)
static int mpc52xx_fec_mdio_remove(struct platform_device *of)
{
- struct device *dev = &of->dev;
- struct mii_bus *bus = dev_get_drvdata(dev);
+ struct mii_bus *bus = platform_get_drvdata(of);
struct mpc52xx_fec_mdio_priv *priv = bus->priv;
mdiobus_unregister(bus);
- dev_set_drvdata(dev, NULL);
iounmap(priv->regs);
kfree(priv);
mdiobus_free(bus);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND 3/8] net: fec_mpc52xx_phy: use platform_{get,set}_drvdata()
2013-08-12 13:24 [PATCH 3/8] net: fec_mpc52xx_phy: use platform_{get,set}_drvdata() Libo Chen
@ 2013-08-14 3:39 ` Libo Chen
0 siblings, 0 replies; 2+ messages in thread
From: Libo Chen @ 2013-08-14 3:39 UTC (permalink / raw)
To: David Miller; +Cc: netdev, LKML, Li Zefan
We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &of->dev, it is convenient for user.
Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
index 360a578..e052890 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
@@ -123,12 +123,10 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of)
static int mpc52xx_fec_mdio_remove(struct platform_device *of)
{
- struct device *dev = &of->dev;
- struct mii_bus *bus = dev_get_drvdata(dev);
+ struct mii_bus *bus = platform_get_drvdata(of);
struct mpc52xx_fec_mdio_priv *priv = bus->priv;
mdiobus_unregister(bus);
- dev_set_drvdata(dev, NULL);
iounmap(priv->regs);
kfree(priv);
mdiobus_free(bus);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-14 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 13:24 [PATCH 3/8] net: fec_mpc52xx_phy: use platform_{get,set}_drvdata() Libo Chen
2013-08-14 3:39 ` [PATCH RESEND " Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox