Re: [PATCH] userns: initialize the depth of user_namespace chain

Rui Xiang
2013-08-14T06:45:16Z

On 2013/8/14 13:06, Andy Lutomirski wrote:
> On Tue, Aug 13, 2013 at 10:04 PM, Rui Xiang <rui.xiang@huawei.com> wrote:
>> The level of init_user_ns shoule be 1.
>
> What's wrong with zero?
>

No problem. It is just consistent with commit 8742f229b63, IMHO.
but the initialization of level should be necessary.

Thanks.

> --Andy
>
>>
>> Signed-off-by: Rui Xiang <rui.xiang@huawei.com>
>> ---
>> kernel/user.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/user.c b/kernel/user.c
>> index 69b4c3d..32da187 100644
>> --- a/kernel/user.c
>> +++ b/kernel/user.c
>> @@ -48,6 +48,7 @@ struct user_namespace init_user_ns = {
>> },
>> },
>> .count = ATOMIC_INIT(3),
>> + .level = 1,
>> .owner = GLOBAL_ROOT_UID,
>> .group = GLOBAL_ROOT_GID,
>> .proc_inum = PROC_USER_INIT_INO,
>> --
>> 1.8.2.2
>>
>
>
>