From: Jason Baron <jbaron@akamai.com>
To: Joe Perches <joe@perches.com>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Xenia Ragiadakou <burzalodowa@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Dynamic debug on by default?
Date: Wed, 14 Aug 2013 14:21:10 -0400 [thread overview]
Message-ID: <520BCA96.5020106@akamai.com> (raw)
In-Reply-To: <1376499114.1949.81.camel@joe-AO722>
On 08/14/2013 12:51 PM, Joe Perches wrote:
> On Wed, 2013-08-14 at 09:40 -0700, Sarah Sharp wrote:
>> Hi Xenia,
>>
>> I'm a bit confused. I thought that debugging messages would be turned
>> off by default for a module if CONFIG_DYNAMIC_DEBUG was turned on. When
>> I tested your patch to remove the CONFIG_USB_XHCI_HCD_DEBUGGING and just
>> use dev_dbg, the messages from the xHCI driver appeared in dmesg by
>> default.
>>
>> That generates a lot of log spew. We can have distros add a boot
>> parameter option to turn off debug messages, but that boot parameter is
>> limited to 1023 characters. I'm concerned that if more drivers add
>> dynamic debugging, the distros will eventually run out of space in the
>> dynamic debugging boot parameter. I know Greg was ripping out debugging
>> config options in other USB drivers, so this is a bit concerning.
>>
>> Jason, is there a way within the xHCI driver to say that dynamic
>> debugging should be off by default? I've looked through the
>> documentation, and I can't find anything like that documented.
> #undefine DEBUG
>
>> I've attached my .config file, in case I have something misconfigured.
> Because of:
>
> drivers/usb/host/Makefile:ccflags-$(CONFIG_USB_DEBUG) := -DDEBUG
>
> you probably want to turn this off
>
> CONFIG_USB_DEBUG=y
>
> when dynamic_debug is on.
They should also be emitted in the case that dynamic_debug is off, but
we have set -DDEBUG, right? That was the whole point of enabling them
for dynamic debug too - to mirror the behavior of !CONFIG_DYNAMIC_DEBUG
case.
-Jason
> CONFIG_DYNAMIC_DEBUG=y
>
> This will cause all pr_debug/dev_dbg statements to be
> emitted without specific enabling via the dynamic_debug
> control file.
>
> (from include/linux/dynamic_debug.h)
>
> #if defined DEBUG
> #define _DPRINTK_FLAGS_DEFAULT _DPRINTK_FLAGS_PRINT
> #else
> #define _DPRINTK_FLAGS_DEFAULT 0
> #endif
>
>
prev parent reply other threads:[~2013-08-14 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 16:40 Dynamic debug on by default? Sarah Sharp
2013-08-14 16:51 ` Joe Perches
2013-08-14 17:04 ` Greg KH
2013-08-14 17:20 ` Sarah Sharp
2013-08-14 18:02 ` Greg KH
2013-08-14 18:21 ` Jason Baron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BCA96.5020106@akamai.com \
--to=jbaron@akamai.com \
--cc=burzalodowa@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox