From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760218Ab3HODSR (ORCPT ); Wed, 14 Aug 2013 23:18:17 -0400 Received: from mail.active-venture.com ([67.228.131.205]:52419 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759988Ab3HODSQ (ORCPT ); Wed, 14 Aug 2013 23:18:16 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <520C4879.7000204@roeck-us.net> Date: Wed, 14 Aug 2013 20:18:17 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Julia Lawall CC: Wim Van Sebroeck , kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/29] watchdog: ts72xx_wdt: simplify use of devm_ioremap_resource References: <1376471493-22215-1-git-send-email-Julia.Lawall@lip6.fr> <1376471493-22215-20-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1376471493-22215-20-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2013 02:11 AM, Julia Lawall wrote: > From: Julia Lawall > > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to devm_ioremap_resource. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression pdev,res,n,e,e1; > expression ret != 0; > identifier l; > @@ > > - res = platform_get_resource(pdev, IORESOURCE_MEM, n); > ... when != res > - if (res == NULL) { ... \(goto l;\|return ret;\) } > ... when != res > + res = platform_get_resource(pdev, IORESOURCE_MEM, n); > e = devm_ioremap_resource(e1, res); > // > > Signed-off-by: Julia Lawall > Reviewed-by: Guenter Roeck