* [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()
@ 2013-08-15 13:01 Libo Chen
2013-08-15 22:23 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Libo Chen @ 2013-08-15 13:01 UTC (permalink / raw)
To: David Miller
Cc: michal.simek, renner, Greg KH, LKML, Li Zefan, Sergei Shtylyov,
monstr
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index fd4dbda..7c1ccbc 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1230,8 +1230,7 @@ error:
*/
static int xemaclite_of_remove(struct platform_device *of_dev)
{
- struct device *dev = &of_dev->dev;
- struct net_device *ndev = dev_get_drvdata(dev);
+ struct net_device *ndev = platform_get_drvdata(of_dev);
struct net_local *lp = netdev_priv(ndev);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()
2013-08-15 13:01 [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata() Libo Chen
@ 2013-08-15 22:23 ` David Miller
2013-08-16 1:09 ` Libo Chen
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-08-15 22:23 UTC (permalink / raw)
To: clbchenlibo.chen
Cc: michal.simek, renner, gregkh, linux-kernel, lizefan,
sergei.shtylyov, monstr
From: Libo Chen <clbchenlibo.chen@huawei.com>
Date: Thu, 15 Aug 2013 21:01:47 +0800
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Why did you not CC: netdev on this patch?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()
2013-08-15 22:23 ` David Miller
@ 2013-08-16 1:09 ` Libo Chen
0 siblings, 0 replies; 3+ messages in thread
From: Libo Chen @ 2013-08-16 1:09 UTC (permalink / raw)
To: David Miller
Cc: michal.simek, renner, gregkh, linux-kernel, lizefan,
sergei.shtylyov, monstr
On 2013/8/16 6:23, David Miller wrote:
> From: Libo Chen <clbchenlibo.chen@huawei.com>
> Date: Thu, 15 Aug 2013 21:01:47 +0800
>
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
>> so we can directly pass a struct platform_device.
>>
>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
>
> Why did you not CC: netdev on this patch?
>
oh, my script doesn`t work well!
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-16 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-15 13:01 [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata() Libo Chen
2013-08-15 22:23 ` David Miller
2013-08-16 1:09 ` Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox