From: Doug Ledford <dledford@redhat.com>
To: Sasikantha Babu <sasikanth.v19@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ipc/mq: Removed unused def_attr local variable and its initialization in do_create
Date: Thu, 15 Aug 2013 16:06:47 -0400 [thread overview]
Message-ID: <520D34D7.9080208@redhat.com> (raw)
In-Reply-To: <1376320182-2118-2-git-send-email-sasikanth.v19@gmail.com>
On 08/12/2013 11:09 AM, Sasikantha Babu wrote:
> In the first patch since we removed calling mq_attr_ok to validate
> mqueue attributes default/ceil values, So removing the unused def_attr
>
> Signed-off-by: Sasikantha Babu <sasikanth.v19@gmail.com>
> ---
> ipc/mqueue.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 04ece80..0bcf69c 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -741,13 +741,6 @@ static struct file *do_create(struct ipc_namespace *ipc_ns, struct inode *dir,
> return ERR_PTR(ret);
> /* store for use during create */
> path->dentry->d_fsdata = attr;
> - } else {
> - struct mq_attr def_attr;
> -
> - def_attr.mq_maxmsg = min(ipc_ns->mq_msg_max,
> - ipc_ns->mq_msg_default);
> - def_attr.mq_msgsize = min(ipc_ns->mq_msgsize_max,
> - ipc_ns->mq_msgsize_default);
> }
>
> mode &= ~current_umask();
>
Nak to this patch as well since it depends on the previous patch.
next prev parent reply other threads:[~2013-08-15 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 15:09 [PATCH 1/2] ipc/mq: Do not vaild queue attributes default/ceiling value If the user pass attr as NULL Sasikantha Babu
2013-08-12 15:09 ` [PATCH 2/2] ipc/mq: Removed unused def_attr local variable and its initialization in do_create Sasikantha Babu
2013-08-15 20:06 ` Doug Ledford [this message]
2013-08-15 20:01 ` [PATCH 1/2] ipc/mq: Do not vaild queue attributes default/ceiling value If the user pass attr as NULL Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520D34D7.9080208@redhat.com \
--to=dledford@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sasikanth.v19@gmail.com \
--cc=vdavydov@parallels.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).