From: Richard Weinberger <richard@nod.at>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH] print_worker_info: Handle pointer with more care
Date: Fri, 16 Aug 2013 19:20:41 +0200 [thread overview]
Message-ID: <520E5F69.8080207@nod.at> (raw)
In-Reply-To: <520E58F3.4080309@nod.at>
Am 16.08.2013 18:53, schrieb Richard Weinberger:
>> Yeah, and that should be fine. &pwq->wq would be just an offset of wq
>
> Yep. Now my brain also parsed the C notation correctly.
> Sorry for the completely wrong patch.
>
>> from NULL which is an invalid pointer but probe_kernel_read() should
>> be able to handle that and probably just return 0 or -1 (all bits
>> set). I *think* what's necessary is making probe_kernel_read() use
>> mincore() to fine out whether the requested address is mapped (it
>> should return -EFAULT if not) and try to dereference the address iff
>> it's mapped.
>
> UML needs a custom probe_kernel_read()? Fine. :)
With my own probe_kernel_read() that uses mincore()
it works fine so far. :-)
Thanks,
//richard
prev parent reply other threads:[~2013-08-16 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 15:56 [PATCH] print_worker_info: Handle pointer with more care Richard Weinberger
2013-08-16 16:12 ` Tejun Heo
2013-08-16 16:15 ` Richard Weinberger
2013-08-16 16:28 ` Tejun Heo
2013-08-16 16:38 ` Richard Weinberger
2013-08-16 16:45 ` Tejun Heo
2013-08-16 16:53 ` Richard Weinberger
2013-08-16 17:20 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E5F69.8080207@nod.at \
--to=richard@nod.at \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox