The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
	kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] arch_topology: Fix incorrect error check in topology_parse_cpu_capacity()
Date: Tue, 23 Sep 2025 09:46:34 +0200	[thread overview]
Message-ID: <520bab83-191e-4907-8d47-3d9ef8c7c269@web.de> (raw)
In-Reply-To: <20250923072520.3964688-1-kaushlendra.kumar@intel.com>

…
> returns NULL. Replace with IS_ERR_OR_NULL() which correctly identifies
> only valid pointers, ensuring clk_get_rate() is called only with valid
> clock objects.

* Can the change description be refined based on documented macro call properties?
  https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/err.h#L101-L123

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?


Regards,
Markus

  reply	other threads:[~2025-09-23  7:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  7:25 [PATCH] arch_topology: Fix incorrect error check in topology_parse_cpu_capacity() Kaushlendra Kumar
2025-09-23  7:46 ` Markus Elfring [this message]
2025-09-23  8:50   ` Kumar, Kaushlendra
2025-09-23  8:40 ` Sudeep Holla
2025-09-23 10:24   ` Dan Carpenter
2025-09-23 10:27     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520bab83-191e-4907-8d47-3d9ef8c7c269@web.de \
    --to=markus.elfring@web.de \
    --cc=dakr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kaushlendra.kumar@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox