From: "Svenning Sørensen" <sss@secomea.dk>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Felipe Balbi <balbi@ti.com>,
kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource
Date: Mon, 19 Aug 2013 13:59:28 +0200 [thread overview]
Message-ID: <521208A0.5010602@secomea.dk> (raw)
In-Reply-To: <alpine.DEB.2.02.1308191334340.2313@hadrien>
On 19-08-2013 13:35, Julia Lawall wrote:
> reg_base = devm_ioremap_resource(dev, r);
> if (!musb->ctrl_base)
> return -EINVAL;
>> Not really related to Julia's patch, apart from making it more obvious that
>> there's a bug here.
>> I believe it is reg_base that needs to be checked, right?
> Indeed, it is all backwards. I could extend the patch, if you want.
>
I'll let Felipe decide on that, but I can't imagine any objections.
IS_ERR() is the proper test, of course :)
Svenning
next prev parent reply other threads:[~2013-08-19 11:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 8:51 [PATCH 0/6] simplify platform_get_resource_byname/devm_ioremap_resource Julia Lawall
2013-08-19 8:51 ` [PATCH 1/6] ASoC: omap: " Julia Lawall
2013-08-19 18:02 ` Jarkko Nikula
2013-08-20 10:51 ` Mark Brown
2013-08-19 8:51 ` [PATCH 2/6] watchdog: " Julia Lawall
2013-08-19 13:06 ` Guenter Roeck
2013-08-19 8:51 ` [PATCH 3/6] mtd: fsmc_nand: " Julia Lawall
2013-08-19 13:38 ` Artem Bityutskiy
2013-08-19 8:51 ` [PATCH 4/6] usb: musb: dsps: " Julia Lawall
2013-08-19 11:17 ` Svenning Sørensen
2013-08-19 11:35 ` Julia Lawall
2013-08-19 11:59 ` Svenning Sørensen [this message]
2013-08-19 12:00 ` Julia Lawall
2013-08-19 11:47 ` [PATCH 4/6 v2] " Julia Lawall
2013-08-19 14:29 ` Sergei Shtylyov
2013-08-19 14:32 ` Julia Lawall
2013-08-19 14:44 ` Dan Carpenter
2013-08-19 8:51 ` [PATCH 5/6] regulator: ti-abb: " Julia Lawall
2013-08-19 9:10 ` walter harms
2013-08-19 9:12 ` Julia Lawall
2013-08-19 10:12 ` Julia Lawall
2013-08-19 10:17 ` walter harms
2013-08-19 10:23 ` Julia Lawall
2013-08-19 10:16 ` Julia Lawall
2013-08-22 10:15 ` Mark Brown
2013-08-19 8:51 ` [PATCH 6/6] MIPS: ath79: " Julia Lawall
2013-08-22 17:50 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521208A0.5010602@secomea.dk \
--to=sss@secomea.dk \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox