From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: i2c-hid: use correct type for ACPI _DSM parameter
Date: Mon, 19 Aug 2013 15:39:50 +0200 [thread overview]
Message-ID: <52122026.2010700@redhat.com> (raw)
In-Reply-To: <1376910077-24433-1-git-send-email-mika.westerberg@linux.intel.com>
On 19/08/13 13:01, Mika Westerberg wrote:
> ACPI 5.0 specification requires the fourth parameter to the _DSM (Device
> Specific Method) to be of type package instead of integer. Failing to do
> that we get following warning on the console:
>
> ACPI Warning: \_SB_.PCI0.I2C1.TPL0._DSM: Argument #4 type mismatch - Found [Integer],
> ACPI requires [Package] (20130517/nsarguments-95)
>
> Fix this by passing an empty package to the _DSM method. The HID over I2C
> specification doesn't require any specific values to be passed with this
> parameter.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Looks simple and straightforward :)
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
next prev parent reply other threads:[~2013-08-19 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 11:01 [PATCH] HID: i2c-hid: use correct type for ACPI _DSM parameter Mika Westerberg
2013-08-19 13:39 ` Benjamin Tissoires [this message]
2013-08-20 10:27 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52122026.2010700@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox