* [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call()
@ 2013-08-14 2:20 Li Wang
2013-08-20 2:21 ` Li.Wang
0 siblings, 1 reply; 2+ messages in thread
From: Li Wang @ 2013-08-14 2:20 UTC (permalink / raw)
To: tglx, mingo, hpa, x86, linux-kernel; +Cc: li.wang
When cpuidle_idle_call() return 0, it shows that linux system is using
idle framwork driver. Now, local irq has already been enabled in
cpuidle_idle_call(). So, it need not enable local irq again, when return 0.
The code is introduced by commit:
97a5b81fa4d3a11dcdf224befc577f2e0abadc0b ("x86: Fix idle consolidation fallout")
In that defect, it does not use idle framework driver, just call amd_e400_idle().
That problem is that amd_e400_idle() does not enable irq.
Signed-off-by: Li Wang <li.wang@windriver.com>
---
arch/x86/kernel/process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 83369e5..cb55ee4 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -300,8 +300,6 @@ void arch_cpu_idle(void)
{
if (cpuidle_idle_call())
x86_idle();
- else
- local_irq_enable();
}
/*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call()
2013-08-14 2:20 [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call() Li Wang
@ 2013-08-20 2:21 ` Li.Wang
0 siblings, 0 replies; 2+ messages in thread
From: Li.Wang @ 2013-08-20 2:21 UTC (permalink / raw)
To: tglx, mingo, hpa, x86, linux-kernel
Hi All,
Anybody help me review this?
Thanks,
LiWang.
On 08/14/2013 10:20 AM, Li Wang wrote:
> When cpuidle_idle_call() return 0, it shows that linux system is using
> idle framwork driver. Now, local irq has already been enabled in
> cpuidle_idle_call(). So, it need not enable local irq again, when return 0.
>
> The code is introduced by commit:
> 97a5b81fa4d3a11dcdf224befc577f2e0abadc0b ("x86: Fix idle consolidation fallout")
> In that defect, it does not use idle framework driver, just call amd_e400_idle().
> That problem is that amd_e400_idle() does not enable irq.
>
> Signed-off-by: Li Wang <li.wang@windriver.com>
> ---
> arch/x86/kernel/process.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 83369e5..cb55ee4 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -300,8 +300,6 @@ void arch_cpu_idle(void)
> {
> if (cpuidle_idle_call())
> x86_idle();
> - else
> - local_irq_enable();
> }
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-20 4:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-14 2:20 [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call() Li Wang
2013-08-20 2:21 ` Li.Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox