public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markku Savela <msa@moth.iki.fi>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Cong Wang <amwang@redhat.com>, David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, james.l.morris@oracle.com,
	sds@tycho.nsa.gov, eparis@parisplace.org, pmoore@redhat.com,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [Patch net-next v3 9/9] selinux: use generic union inet_addr
Date: Tue, 20 Aug 2013 17:48:00 +0300	[thread overview]
Message-ID: <521381A0.9050304@moth.iki.fi> (raw)
In-Reply-To: <52137CFF.70601@schaufler-ca.com>


Imho, the patch doesn't go far enough actually. What should be done:

- get rid of the union
- use IPv6 format only
- store IPv4 addresses in IPv4 mapped format



  reply	other threads:[~2013-08-20 14:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1376907278-26377-1-git-send-email-amwang@redhat.com>
2013-08-19 10:14 ` [Patch net-next v3 2/9] net: rename '%pIS' to '%pIA' for union inet_addr Cong Wang
2013-08-19 10:14 ` [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Cong Wang
2013-08-19 14:37   ` Christoph Hellwig
2013-08-19 10:14 ` [Patch net-next v3 9/9] selinux: use generic union inet_addr Cong Wang
2013-08-19 19:34   ` Casey Schaufler
2013-08-19 19:50     ` David Miller
2013-08-19 21:42       ` Casey Schaufler
2013-08-20  6:48         ` David Miller
2013-08-20 13:01         ` Cong Wang
2013-08-20 14:28           ` Casey Schaufler
2013-08-20 14:48             ` Markku Savela [this message]
2013-08-22  5:03             ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521381A0.9050304@moth.iki.fi \
    --to=msa@moth.iki.fi \
    --cc=amwang@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=davem@davemloft.net \
    --cc=eparis@parisplace.org \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmoore@redhat.com \
    --cc=sds@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox