Re: [PATCH v2 2/3] workqueue: Fix manage_workers() RETURNS description

[Randy Dunlap <rdunlap@infradead.org>]

On 08/20/13 17:50, Libin wrote:
> No functional change. The comment of function manage_workers()
> RETURNS description is obvious wrong, same as the CONTEXT.
> Fix it.
> 
> Signed-off-by: Libin <huawei.libin@huawei.com>
> ---
>  kernel/workqueue.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 26644ce..46a0de0 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2034,8 +2034,11 @@ static bool maybe_destroy_workers(struct worker_pool *pool)
>   * multiple times.  Does GFP_KERNEL allocations.
>   *
>   * RETURNS:
> - * spin_lock_irq(pool->lock) which may be released and regrabbed
> - * multiple times.  Does GFP_KERNEL allocations.
> + * %false if the pool don't need management and the caller can safely

                         doesn't

> + * start processing works, %true indicates that the function released
> + * pool->lock and reacquired it to perform some management function
> + * and that the conditions that the caller verified while holding the
> + * lock before calling the function might no longer be true.
>   */
>  static bool manage_workers(struct worker *worker)
>  {
> 


-- 
~Randy