public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
Date: Thu, 22 Aug 2013 13:27:16 +0800	[thread overview]
Message-ID: <5215A134.90607@asianux.com> (raw)
In-Reply-To: <20130822051122.GB26773@secunet.com>

On 08/22/2013 01:11 PM, Steffen Klassert wrote:
> On Tue, Aug 20, 2013 at 11:44:31AM +0800, Chen Gang wrote:
>>
>> If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED
>> share the same code.
>>
>> And do we need a comment "/* fall through */" between CPU_UP_CANCELED
>> and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ?
>>
>> At last, also better to let CPU_DOWN_PREPARE and CPU_UP_CANCELED share
>> the same code (if need a 'break'), or share the most of code (if "fall
>> through").
>>
> 
> CPU_ONLINE and CPU_DOWN_FAILED can share the code. Same is true for
> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
> 
> Thanks!
> 
> 

Thank you too.

And need I send another patch for it ?

Or just make by yourself (and better to mark me as Reported-by). :-)


Thanks.
-- 
Chen Gang

  reply	other threads:[~2013-08-22  5:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20  3:43 [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Chen Gang
2013-08-20  3:44 ` Chen Gang
2013-08-22  5:11   ` Steffen Klassert
2013-08-22  5:27     ` Chen Gang [this message]
2013-08-22  6:05       ` Steffen Klassert
2013-08-22  6:16         ` Chen Gang
2013-08-22  6:43         ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
2013-08-23  3:46           ` Chen Gang
2013-08-23 10:44           ` Steffen Klassert
2013-08-23 10:47             ` Herbert Xu
2013-08-26  1:11               ` Chen Gang
2013-08-29  4:42             ` Herbert Xu
2013-08-29  5:22               ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5215A134.90607@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox