From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX
Date: Thu, 22 Aug 2013 12:23:47 +0530 [thread overview]
Message-ID: <5215B57B.80204@nvidia.com> (raw)
In-Reply-To: <1377153008.18701.0.camel@phoenix>
On Thursday 22 August 2013 12:00 PM, Axel Lin wrote:
> Fix below build error if !PINMUX.
>
> CC drivers/pinctrl/pinctrl-palmas.o
> drivers/pinctrl/pinctrl-palmas.c:741:21: error: variable 'palmas_pinmux_ops' has initializer but incomplete type
> drivers/pinctrl/pinctrl-palmas.c:742:2: error: unknown field 'get_functions_count' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: error: unknown field 'get_function_name' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: error: unknown field 'get_function_groups' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: error: unknown field 'enable' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> make[2]: *** [drivers/pinctrl/pinctrl-palmas.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 8542cd4..ae8b747 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -264,6 +264,7 @@ config PINCTRL_EXYNOS5440
> config PINCTRL_PALMAS
> bool "Pinctrl driver for the PALMA Series MFD devices"
> depends on OF && MFD_PALMAS
> + select PINMUX
> select GENERIC_PINCONF
> help
> Palmas device supports the configuration of pins for different
Yes, this is needed. In mainline, it is not creating issue for Tegra as
it is already selecting PINMUX for Tegra.
I found this issue on yesterday only in our downstream when porting it
for new boards with new config.
You won the race of sending patch ;-).
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-08-22 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 6:30 [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX Axel Lin
2013-08-22 6:53 ` Laxman Dewangan [this message]
2013-08-28 11:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215B57B.80204@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox