* [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX
@ 2013-08-22 6:30 Axel Lin
2013-08-22 6:53 ` Laxman Dewangan
2013-08-28 11:15 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-08-22 6:30 UTC (permalink / raw)
To: Linus Walleij; +Cc: Laxman Dewangan, Lee Jones, Stephen Warren, linux-kernel
Fix below build error if !PINMUX.
CC drivers/pinctrl/pinctrl-palmas.o
drivers/pinctrl/pinctrl-palmas.c:741:21: error: variable 'palmas_pinmux_ops' has initializer but incomplete type
drivers/pinctrl/pinctrl-palmas.c:742:2: error: unknown field 'get_functions_count' specified in initializer
drivers/pinctrl/pinctrl-palmas.c:742:2: warning: excess elements in struct initializer [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:742:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:743:2: error: unknown field 'get_function_name' specified in initializer
drivers/pinctrl/pinctrl-palmas.c:743:2: warning: excess elements in struct initializer [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:743:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:744:2: error: unknown field 'get_function_groups' specified in initializer
drivers/pinctrl/pinctrl-palmas.c:744:2: warning: excess elements in struct initializer [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:744:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:745:2: error: unknown field 'enable' specified in initializer
drivers/pinctrl/pinctrl-palmas.c:745:2: warning: excess elements in struct initializer [enabled by default]
drivers/pinctrl/pinctrl-palmas.c:745:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
make[2]: *** [drivers/pinctrl/pinctrl-palmas.o] Error 1
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8542cd4..ae8b747 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -264,6 +264,7 @@ config PINCTRL_EXYNOS5440
config PINCTRL_PALMAS
bool "Pinctrl driver for the PALMA Series MFD devices"
depends on OF && MFD_PALMAS
+ select PINMUX
select GENERIC_PINCONF
help
Palmas device supports the configuration of pins for different
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX
2013-08-22 6:30 [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX Axel Lin
@ 2013-08-22 6:53 ` Laxman Dewangan
2013-08-28 11:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2013-08-22 6:53 UTC (permalink / raw)
To: Axel Lin
Cc: Linus Walleij, Lee Jones, Stephen Warren,
linux-kernel@vger.kernel.org
On Thursday 22 August 2013 12:00 PM, Axel Lin wrote:
> Fix below build error if !PINMUX.
>
> CC drivers/pinctrl/pinctrl-palmas.o
> drivers/pinctrl/pinctrl-palmas.c:741:21: error: variable 'palmas_pinmux_ops' has initializer but incomplete type
> drivers/pinctrl/pinctrl-palmas.c:742:2: error: unknown field 'get_functions_count' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:742:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: error: unknown field 'get_function_name' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:743:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: error: unknown field 'get_function_groups' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:744:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: error: unknown field 'enable' specified in initializer
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: excess elements in struct initializer [enabled by default]
> drivers/pinctrl/pinctrl-palmas.c:745:2: warning: (near initialization for 'palmas_pinmux_ops') [enabled by default]
> make[2]: *** [drivers/pinctrl/pinctrl-palmas.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 8542cd4..ae8b747 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -264,6 +264,7 @@ config PINCTRL_EXYNOS5440
> config PINCTRL_PALMAS
> bool "Pinctrl driver for the PALMA Series MFD devices"
> depends on OF && MFD_PALMAS
> + select PINMUX
> select GENERIC_PINCONF
> help
> Palmas device supports the configuration of pins for different
Yes, this is needed. In mainline, it is not creating issue for Tegra as
it is already selecting PINMUX for Tegra.
I found this issue on yesterday only in our downstream when porting it
for new boards with new config.
You won the race of sending patch ;-).
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX
2013-08-22 6:30 [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX Axel Lin
2013-08-22 6:53 ` Laxman Dewangan
@ 2013-08-28 11:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-08-28 11:15 UTC (permalink / raw)
To: Axel Lin
Cc: Laxman Dewangan, Lee Jones, Stephen Warren,
linux-kernel@vger.kernel.org
On Thu, Aug 22, 2013 at 8:30 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix below build error if !PINMUX.
>
> CC drivers/pinctrl/pinctrl-palmas.o
Patch applied with Laxman's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-28 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 6:30 [PATCH] pinctrl: palmas: PINCTRL_PALMAS needs to select PINMUX Axel Lin
2013-08-22 6:53 ` Laxman Dewangan
2013-08-28 11:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox