public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael wang <wangyun@linux.vnet.ibm.com>
To: open list <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, linux-acpi@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	John Stultz <john.stultz@linaro.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Feng Tang <feng.tang@intel.com>
Subject: Re: [PATCH 08/11] sched/cleanup: remove the extra parm of sched_clock_idle_wakeup_event()
Date: Thu, 22 Aug 2013 16:07:50 +0800	[thread overview]
Message-ID: <5215C6D6.3030309@linux.vnet.ibm.com> (raw)
In-Reply-To: <5215C484.5010407@linux.vnet.ibm.com>

On 08/22/2013 03:57 PM, Michael wang wrote:
> Parm 'delta_ns' has not been used, remove it to make code clean.
[snip]
>  
> -extern void sched_clock_idle_sleep_event(void);
> -extern void sched_clock_idle_wakeup_event(u64 delta_ns);

Also remove the extra declaration here.

Regards,
Michael Wang

> -
>  #ifdef CONFIG_HOTPLUG_CPU
>  extern void idle_task_exit(void);
>  #else
> diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
> index c3ae144..d111c58 100644
> --- a/kernel/sched/clock.c
> +++ b/kernel/sched/clock.c
> @@ -294,7 +294,7 @@ EXPORT_SYMBOL_GPL(sched_clock_idle_sleep_event);
>  /*
>   * We just idled delta nanoseconds (called with irqs disabled):
>   */
> -void sched_clock_idle_wakeup_event(u64 delta_ns)
> +void sched_clock_idle_wakeup_event(void)
>  {
>  	if (timekeeping_suspended)
>  		return;
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 3612fc7..4b24d9e 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -433,7 +433,7 @@ static void tick_nohz_stop_idle(int cpu, ktime_t now)
>  	update_ts_time_stats(cpu, ts, now, NULL);
>  	ts->idle_active = 0;
>  
> -	sched_clock_idle_wakeup_event(0);
> +	sched_clock_idle_wakeup_event();
>  }
>  
>  static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
> 


  reply	other threads:[~2013-08-22  8:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  7:48 [PATCH 00/11] sched/cleanup: scheduler related cleanup and refine Michael wang
2013-08-22  7:49 ` [PATCH 01/11] sched/cleanup: remove the extra line in init_sched_fair_class() Michael wang
2013-08-22  7:50 ` [PATCH 02/11] sched/cleanup: remove the extra parm of alloc_thread_info_node() Michael wang
2013-08-22  7:52 ` [PATCH 03/11] sched/cleanup: remove the extra parm of copy_flags() Michael wang
2013-08-22  7:53 ` [PATCH 04/11] sched/cleanup: refine rt_policy() Michael wang
2013-08-22  7:54 ` [PATCH 05/11] sched/cleanup: remove the extra parm of wakeup_gran() Michael wang
2013-08-22  7:55 ` [PATCH 06/11] sched/cleanup: refine __setup_irq() Michael wang
2013-08-22  7:56 ` [PATCH 07/11] sched/cleanup: remove the extra parm of irq_set_thread_affinity() Michael wang
2013-08-22  7:57 ` [PATCH 08/11] sched/cleanup: remove the extra parm of sched_clock_idle_wakeup_event() Michael wang
2013-08-22  8:07   ` Michael wang [this message]
2013-08-22  7:58 ` [PATCH 09/11] sched/cleanup: remove the extra parm of tick_nohz_start_idle() Michael wang
2013-08-22  7:59 ` [PATCH 10/11] sched/cleanup: remove the extra parm of retrigger_next_event() Michael wang
2013-08-22  7:59 ` [PATCH 11/11] sched/cleanup: remove the extra parm of find_new_ilb() Michael wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5215C6D6.3030309@linux.vnet.ibm.com \
    --to=wangyun@linux.vnet.ibm.com \
    --cc=feng.tang@intel.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox