public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, john stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH] Disable TSCs on CONFIG_MULTIQUAD
Date: Wed, 29 May 2002 17:54:06 -0700	[thread overview]
Message-ID: <521610000.1022720046@flay> (raw)
In-Reply-To: <1022722675.4124.337.camel@irongate.swansea.linux.org.uk>

>> Anyway, if you really would rather see what you suggested, I'll happily
>> change it (I do like the idea of breaking the CONFIG_X86_TSC_UNSYNCED
>> notion out of CONFIG_MULTIQUAD).
> 
> Not all the other places are "there is no TSC" most of them deal with
> the ability to use a TSC. There are other setups where TSC exists but
> isnt usable so distinguishing matters

I think the CONFIG_X86_TSC option is most confusing (bad naming, at
best).

Without CONFIG_X86_TSC:
You get the ability to have a TSC or not, both code paths are compiled
in, and it dynamically detects at boot time. You can override this with the
"notsc" option, or overriding the tsc_disable variable, as we did here.

With CONFIG_X86_TSC:
You remove all the code which supports non-TSC systems.

Perhaps I'm just mentally slow, but I think my little brain would find this
area easier of it was called CONFIG_X86_ONLY_TSC or some such.

So if John's patch was rewritten to leave the CPU type switching on
CONFIG_X86_TSC, then have the multiquad switch turn that into 
CONFIG_X86_ONLY_TSC (and change the in code #ifdefs to that)
would that be more palletable? Would make things more readable in
the main code to my mind ....

M.


  reply	other threads:[~2002-05-30  0:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-29 20:40 [RFC] [PATCH] Disable TSCs on CONFIG_MULTIQUAD john stultz
2002-05-29 22:52 ` Alan Cox
2002-05-30  0:20   ` john stultz
2002-05-30  1:37     ` Alan Cox
2002-05-30  0:54       ` Martin J. Bligh [this message]
2002-05-30  1:36       ` john stultz
2002-05-30 18:50   ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521610000.1022720046@flay \
    --to=martin.bligh@us.ibm.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox