Re: [RFC] [PATCH] Disable TSCs on CONFIG_MULTIQUAD

john stultz
2002-05-30T00:24:17Z

> Add CONFIG_X86_TSC_NOT_SYNCHRONOUS or similar and then check
>
> #if defined(CONFIG_X86_TSC) && !defined(CONFIG_X86_NOT_SYNCHRONOUS))

<laugh> I guess I asked for it. :) I actually implemented something
similar to the above earlier, and was convinced out of it. The trade off
with this method is that while it simplifies the config.in changes, it
complicates the 12 or so #ifdef CONFIG_X86_TSC lines.

Keeping the "multi-quad TSCs are broken" fact in just one place
(config.in), rather then spread about the tree in precompiler
statements, seems like the best choice to me. I was actually hoping
there was a good config.in trick for turning CONFIG_X86_TSC off after it
had already been turned on, rather then adding a meta-option, but I'm
guessing there isn't.

Anyway, if you really would rather see what you suggested, I'll happily
change it (I do like the idea of breaking the CONFIG_X86_TSC_UNSYNCED
notion out of CONFIG_MULTIQUAD).

Thanks for the feedback!
-john