* [PATCH] samsung-laptop: fix config build error
@ 2013-08-22 16:06 Randy Dunlap
2013-09-03 12:07 ` Matthew Garrett
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2013-08-22 16:06 UTC (permalink / raw)
To: LKML, Platform Driver; +Cc: Corentin Chary, Fengguang Wu, Matthew Garrett
From: Randy Dunlap <rdunlap@infradead.org>
Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y.
The patch prevents that specific config combination.
drivers/built-in.o: In function `samsung_init':
samsung-laptop.c:(.init.text+0x128ff): undefined reference to `acpi_video_unregister'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Corentin Chary <corentin.chary@gmail.com>
build testing:
ACPI_VIDEO=m, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=m: OK
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20130820.orig/drivers/platform/x86/Kconfig
+++ linux-next-20130820/drivers/platform/x86/Kconfig
@@ -732,6 +732,7 @@ config SAMSUNG_LAPTOP
tristate "Samsung Laptop driver"
depends on X86
depends on RFKILL || RFKILL = n
+ depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on BACKLIGHT_CLASS_DEVICE
select LEDS_CLASS
select NEW_LEDS
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] samsung-laptop: fix config build error
2013-08-22 16:06 [PATCH] samsung-laptop: fix config build error Randy Dunlap
@ 2013-09-03 12:07 ` Matthew Garrett
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Garrett @ 2013-09-03 12:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Platform Driver, Corentin Chary, Fengguang Wu
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 446 bytes --]
On Thu, 2013-08-22 at 09:06 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y.
> The patch prevents that specific config combination.
Applied, thanks.
--
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-03 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 16:06 [PATCH] samsung-laptop: fix config build error Randy Dunlap
2013-09-03 12:07 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).