From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Steve Cotton <steve@s.cotton.clara.co.uk>
Subject: Re: Commit 9a11899 (USB: OHCI: add missing PCI PM callbacks to ohci-pci.c) breaks several builds
Date: Sun, 25 Aug 2013 21:56:15 -0700 [thread overview]
Message-ID: <521ADFEF.2010307@roeck-us.net> (raw)
In-Reply-To: <20130826042653.GA2778@kroah.com>
On 08/25/2013 09:26 PM, Greg Kroah-Hartman wrote:
> On Sun, Aug 25, 2013 at 09:02:15PM -0700, Guenter Roeck wrote:
>> On 08/25/2013 08:30 PM, Guenter Roeck wrote:
>>> Broken builds:
>>> mips:ath79_defconfig
>>> parisc:defconfig
>>> sparc32:defconfig
>>> sparc64:defconfig
>>> tile:defconfig
>>>
>> Add:
>> powerpc:ppc64e_defconfig
>> powerpc:cell_defconfig
>> powerps:maple_defconfig
>>
>> That makes it 8 out of 82 builds, or roughly 10% of all builds.
>>
>> My qemu test build for powerpc (which has its own config file) fails as well :(.
>
> Ugh, I got no reports of this from linux-next or the 0-day build system,
> odd.
>
Maybe the build system isn't as comprehensive as mine, or it just takes a bit longer.
My system caught it because you updated linux-stable to 3.11-rc7, which triggers all builds.
The functions are only declared if CONFIG_PM is defined, yet are called unconditionally.
This means the patch breaks in all configurations where CONFIG_PM is undefined and
CONFIG_USB_OHCI_HCD_PCI is defined.
Add this to the agenda at the kernel summit: We need more automated test coverage.
It is a bit scary that my little pc-based server farm catches problems like this
faster than everything else out there. And it isn't even the kind of problem
I am looking for, but rather a side effect of the builds I am running.
Guenter
next prev parent reply other threads:[~2013-08-26 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 3:30 Commit 9a11899 (USB: OHCI: add missing PCI PM callbacks to ohci-pci.c) breaks several builds Guenter Roeck
2013-08-26 4:02 ` Guenter Roeck
2013-08-26 4:26 ` Greg Kroah-Hartman
2013-08-26 4:56 ` Guenter Roeck [this message]
2013-08-26 14:47 ` Alan Stern
2013-08-26 14:53 ` [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume Alan Stern
2013-08-26 15:38 ` Greg Kroah-Hartman
2013-08-26 16:06 ` Guenter Roeck
2013-08-26 16:50 ` Greg Kroah-Hartman
2013-08-26 17:19 ` Guenter Roeck
2013-08-26 22:14 ` Greg Kroah-Hartman
2013-08-26 22:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521ADFEF.2010307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=steve@s.cotton.clara.co.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox