Re: [PATCH] h8300: include: asm: Kbuild: add gpio.h for pass compiling

[Chen Gang <gang.chen@asianux.com>]

On 08/26/2013 06:59 PM, Chen Gang wrote:
> On 08/26/2013 06:21 PM, Geert Uytterhoeven wrote:
>> On Mon, Aug 26, 2013 at 12:16 PM, Chen Gang <gang.chen@asianux.com> wrote:
>>> Need add default "gpio.h" for h8300, or can not pass compiling.
>>>
>>> The related error (allmodconfig for h8300):
>>>
>>>   arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory
>>>    #include <asm/gpio.h>
>>>                         ^
>>
>> I this include needed at all? Perhaps it can just be removed?
>>
> 
> Pardon ?  Do you mean, only removing it  will be OK ?
> 
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>> ---
>>>  arch/h8300/include/asm/Kbuild |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild
>>> index 8ada3cf..4c627aa 100644
>>> --- a/arch/h8300/include/asm/Kbuild
>>> +++ b/arch/h8300/include/asm/Kbuild
>>> @@ -1,6 +1,7 @@
>>>
>>>  generic-y += clkdev.h
>>>  generic-y += exec.h
>>> +generic-y += gpio.h
>>>  generic-y += linkage.h
>>>  generic-y += mmu.h
>>>  generic-y += module.h
>>
>> The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are:
>>
>> EXPORT_SYMBOL(h8300_reserved_gpio);
>> EXPORT_SYMBOL(h8300_free_gpio);
>> EXPORT_SYMBOL(h8300_set_gpio_dir);
>>
>> and these are definitely not provided by asm-generic/gpio.h.
>>
> 
> Yeah, I will try to remove "#include <asm/gpio.h>" to see whether can
> pass compiling, tomorrow.  :-)
> 
> And now, I feel (just guess), it will not, for h8300 really need gpio
> (it has "gpio-internal.h"), commonly it will need "asm/gpio.h" too.
> 
> Tomorrow, I will try to prove whether my guess is correct or not.  ;-).
> 

After reading the related code (search "gpio.h" in root source tree),
it seems what you said is correct, my guess is incorrect.  :-(

Hmm... but better to get final conclusion after finish allmodconfig
compiling.

Now, I am compiling, and excuse me, I can not finish today because of
some issues (mainly for 'gcc 4.8.0', part for 'ld 2.22', and part for
kernel), I will 'process' them, hope can finish before 2013-08-31.


Welcome additional suggestions or completions.

Thanks.

> 
> Thanks.
> 
>> Gr{oetje,eeting}s,
>>
>>                         Geert
>>
>> --
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a hacker. But
>> when I'm talking to journalists I just say "programmer" or something like that.
>>                                 -- Linus Torvalds
>>
>>
> 
> 


-- 
Chen Gang