From: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
To: "Luck, Tony" <tony.luck@intel.com>, Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"jkenisto@linux.vnet.ibm.com" <jkenisto@linux.vnet.ibm.com>,
"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>,
"mahesh@linux.vnet.ibm.com" <mahesh@linux.vnet.ibm.com>,
"ccross@android.com" <ccross@android.com>
Subject: Re: [RFC PATCH v2 04/11] pstore: Add compression support to pstore
Date: Tue, 27 Aug 2013 10:49:48 +0530 [thread overview]
Message-ID: <521C36F4.8030607@linux.vnet.ibm.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F31CC7AC0@ORSMSX106.amr.corp.intel.com>
On Friday 23 August 2013 04:47 AM, Luck, Tony wrote:
> <1>[ 383.209057] RIP [<ffffffff813d3946>] sysrq_handle_crash+0x16/0x20
> <4>[ 383.209057] RSP <ffff88006f551e80>
> <4>[ 383.209057] CR2: 0000000000000000
> <4>[ 383.209057] ---[ end trace 04a1cddad37b4b33 ]---
> <3>[ 383.209057] pstore: compression failed for Part 2 returned -5
> <3>[ 383.209057] pstore: Capture uncompressed oops/panic report of Part 2
> <3>[ 383.209057] pstore: compression failed for Part 5 returned -5
>
> Interesting. With ERST backend I didn't see these messages. Traces in
> pstore recovered files go as far as the line before the "---[ end trace 04a1cddad37b4b33 ]---"
>
> Why the difference depending on which back end is in use?
>
> But I agree that we shouldn't have these messages. They use up space
> in the persistent store that could be better used saving some more lines
> from earlier in the console log.
Yeah. We can remove these messages as it will add to the space consumed. But it
would
be good to know why the compression failed with efivars case.
Seiji,
Could you let us know the efivars buffer size with which the pstore is
registered when
the failure occurred.
Regards,
Aruna
>
> -Tony
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2013-08-27 5:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 13:17 [RFC PATCH v2 00/11] Add (de)compression support to pstore Aruna Balakrishnaiah
2013-08-16 13:17 ` [RFC PATCH v2 01/11] powerpc/pseries: Remove (de)compression in nvram with pstore enabled Aruna Balakrishnaiah
2013-08-16 13:17 ` [RFC PATCH v2 02/11] pstore: Add new argument 'compressed' in pstore write callback Aruna Balakrishnaiah
2013-08-16 13:17 ` [RFC PATCH v2 03/11] pstore/Kconfig: Select ZLIB_DEFLATE and ZLIB_INFLATE when PSTORE is selected Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 04/11] pstore: Add compression support to pstore Aruna Balakrishnaiah
2013-08-22 23:07 ` Seiji Aguchi
2013-08-22 23:17 ` Luck, Tony
2013-08-22 23:47 ` Seiji Aguchi
2013-08-27 5:19 ` Aruna Balakrishnaiah [this message]
2013-09-04 1:44 ` Seiji Aguchi
2013-09-04 6:01 ` Aruna Balakrishnaiah
2013-09-04 16:11 ` Luck, Tony
2013-09-04 16:39 ` Seiji Aguchi
2013-08-16 13:18 ` [RFC PATCH v2 05/11] pstore: Introduce new argument 'compressed' in the read callback Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 06/11] pstore: Add decompression support to pstore Aruna Balakrishnaiah
2013-08-22 23:04 ` Seiji Aguchi
2013-08-27 9:39 ` Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 07/11] pstore: Add file extension to pstore file if compressed Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 08/11] powerpc/pseries: Read and write to the 'compressed' flag of pstore Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 09/11] erst: " Aruna Balakrishnaiah
2013-08-16 13:18 ` [RFC PATCH v2 10/11] efi-pstore: " Aruna Balakrishnaiah
2013-08-16 13:19 ` [RFC PATCH v2 11/11] pstore/ram: " Aruna Balakrishnaiah
2013-08-17 18:26 ` Kees Cook
2013-08-16 22:15 ` [RFC PATCH v2 00/11] Add (de)compression support to pstore Luck, Tony
2013-08-17 18:32 ` Kees Cook
2013-08-19 17:29 ` Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C36F4.8030607@linux.vnet.ibm.com \
--to=aruna@linux.vnet.ibm.com \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox