* [PATCH] xtensa: Fix broken allmodconfig build
@ 2013-08-28 4:06 Guenter Roeck
2013-08-28 4:11 ` Guenter Roeck
2013-09-03 2:55 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2013-08-28 4:06 UTC (permalink / raw)
To: linux-xtensa; +Cc: linux-kernel, Chris Zankel, Guenter Roeck, Max Filippov
xtansa allmodbuild fails with:
arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function)
make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
make[1]: *** [arch/xtensa/kernel] Error 2
The breakage is due to commit 478ba61af (xtensa: add static function tracer
support) which exports _mcount without declaring it.
Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/xtensa/kernel/xtensa_ksyms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
index d8507f8..74a60c7 100644
--- a/arch/xtensa/kernel/xtensa_ksyms.c
+++ b/arch/xtensa/kernel/xtensa_ksyms.c
@@ -25,6 +25,7 @@
#include <asm/io.h>
#include <asm/page.h>
#include <asm/pgalloc.h>
+#include <asm/ftrace.h>
#ifdef CONFIG_BLK_DEV_FD
#include <asm/floppy.h>
#endif
--
1.7.9.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xtensa: Fix broken allmodconfig build
2013-08-28 4:06 [PATCH] xtensa: Fix broken allmodconfig build Guenter Roeck
@ 2013-08-28 4:11 ` Guenter Roeck
2013-09-03 2:55 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2013-08-28 4:11 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-xtensa, linux-kernel, Chris Zankel, Max Filippov
On 08/27/2013 09:06 PM, Guenter Roeck wrote:
> xtansa allmodbuild fails with:
>
Grmpf.
s/xtansa/xtensa
Guenter
> arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function)
> make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
> make[1]: *** [arch/xtensa/kernel] Error 2
>
> The breakage is due to commit 478ba61af (xtensa: add static function tracer
> support) which exports _mcount without declaring it.
>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/xtensa/kernel/xtensa_ksyms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
> index d8507f8..74a60c7 100644
> --- a/arch/xtensa/kernel/xtensa_ksyms.c
> +++ b/arch/xtensa/kernel/xtensa_ksyms.c
> @@ -25,6 +25,7 @@
> #include <asm/io.h>
> #include <asm/page.h>
> #include <asm/pgalloc.h>
> +#include <asm/ftrace.h>
> #ifdef CONFIG_BLK_DEV_FD
> #include <asm/floppy.h>
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xtensa: Fix broken allmodconfig build
2013-08-28 4:06 [PATCH] xtensa: Fix broken allmodconfig build Guenter Roeck
2013-08-28 4:11 ` Guenter Roeck
@ 2013-09-03 2:55 ` Guenter Roeck
2013-09-06 17:48 ` Chris Zankel
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2013-09-03 2:55 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-xtensa, linux-kernel, Chris Zankel, Max Filippov
On 08/27/2013 09:06 PM, Guenter Roeck wrote:
> xtansa allmodbuild fails with:
>
> arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function)
> make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
> make[1]: *** [arch/xtensa/kernel] Error 2
>
> The breakage is due to commit 478ba61af (xtensa: add static function tracer
> support) which exports _mcount without declaring it.
>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
Ping ... 3.11 now ships with xtensa allmodconfig broken, which is completely unnecessary.
Guenter
> arch/xtensa/kernel/xtensa_ksyms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
> index d8507f8..74a60c7 100644
> --- a/arch/xtensa/kernel/xtensa_ksyms.c
> +++ b/arch/xtensa/kernel/xtensa_ksyms.c
> @@ -25,6 +25,7 @@
> #include <asm/io.h>
> #include <asm/page.h>
> #include <asm/pgalloc.h>
> +#include <asm/ftrace.h>
> #ifdef CONFIG_BLK_DEV_FD
> #include <asm/floppy.h>
> #endif
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xtensa: Fix broken allmodconfig build
2013-09-03 2:55 ` Guenter Roeck
@ 2013-09-06 17:48 ` Chris Zankel
0 siblings, 0 replies; 4+ messages in thread
From: Chris Zankel @ 2013-09-06 17:48 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-xtensa, linux-kernel, Max Filippov
Hi Guenter,
On 9/2/13 7:55 PM, Guenter Roeck wrote:
> On 08/27/2013 09:06 PM, Guenter Roeck wrote:
>> xtansa allmodbuild fails with:
>>
>> arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared
>> here (not in a function)
>> make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
>> make[1]: *** [arch/xtensa/kernel] Error 2
>>
>> The breakage is due to commit 478ba61af (xtensa: add static function
>> tracer
>> support) which exports _mcount without declaring it.
>>
>> Cc: Max Filippov <jcmvbkbc@gmail.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>
> Ping ... 3.11 now ships with xtensa allmodconfig broken, which is
> completely unnecessary.
Sorry for the delay. I just added it to the xtensa for_next tree, and
will push it upstream shortly.
Thanks,
-Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-06 17:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-28 4:06 [PATCH] xtensa: Fix broken allmodconfig build Guenter Roeck
2013-08-28 4:11 ` Guenter Roeck
2013-09-03 2:55 ` Guenter Roeck
2013-09-06 17:48 ` Chris Zankel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox