From: Chen Gang <gang.chen@asianux.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
linux-crypto@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED
Date: Thu, 29 Aug 2013 13:22:49 +0800 [thread overview]
Message-ID: <521EDAA9.5090306@asianux.com> (raw)
In-Reply-To: <20130829044259.GB25208@gondor.apana.org.au>
On 08/29/2013 12:42 PM, Herbert Xu wrote:
> On Fri, Aug 23, 2013 at 12:44:48PM +0200, Steffen Klassert wrote:
>> On Thu, Aug 22, 2013 at 02:43:37PM +0800, Chen Gang wrote:
>>> Share code between CPU_ONLINE and CPU_DOWN_FAILED, same to
>>> CPU_DOWN_PREPARE and CPU_UP_CANCELED.
>>>
>>> It will fix 2 bugs:
>>>
>>> "not check the return value of __padata_remove_cpu() and __padata_add_cpu()".
>>> "need add 'break' between CPU_UP_CANCELED and CPU_DOWN_FAILED".
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> This looks ok to me, Herbert can you take this one?
>>
>> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
>
> Patch applied. Thanks!
>
Thank you too.
--
Chen Gang
prev parent reply other threads:[~2013-08-29 5:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 3:43 [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Chen Gang
2013-08-20 3:44 ` Chen Gang
2013-08-22 5:11 ` Steffen Klassert
2013-08-22 5:27 ` Chen Gang
2013-08-22 6:05 ` Steffen Klassert
2013-08-22 6:16 ` Chen Gang
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
2013-08-23 3:46 ` Chen Gang
2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:47 ` Herbert Xu
2013-08-26 1:11 ` Chen Gang
2013-08-29 4:42 ` Herbert Xu
2013-08-29 5:22 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521EDAA9.5090306@asianux.com \
--to=gang.chen@asianux.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox