From: "H. Peter Anvin" <hpa@zytor.com>
To: "Jan-Simon Möller" <dl9pf@gmx.de>
Cc: llvmlinux@lists.linuxfoundation.org, pageexec@freemail.hu,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue with clang.
Date: Thu, 29 Aug 2013 11:11:32 -0700 [thread overview]
Message-ID: <521F8ED4.2080009@zytor.com> (raw)
In-Reply-To: <6320951.e8eKRZ5b9s@aragorn.auenland.lan>
On 08/29/2013 11:00 AM, Jan-Simon Möller wrote:
>>
>> You just changed the sematics of the _ASM_* macros... that doesn't seem
>> like a great idea. It's probably okay for the registers, but still...
>
> Well, we followed your idea for the _ASM_DX macros as you mentioned them
> earlier.
>
We can probably do this, because register names are usually not assumed
to have spaces around them... so it's probably okay. Definitely a lot
less ugly than the rest. That being said, if we're going to fix these
macros, we should also fix another piece of drain bramage:
ALL instances of these have a % prepended. The % should be part of the
macro.
-hpa
next prev parent reply other threads:[~2013-08-29 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 17:13 [PATCH] [RFC] [X86] Fix a compilation issue with clang dl9pf
2013-08-29 17:28 ` H. Peter Anvin
2013-08-29 18:00 ` [llvmlinux] " Jan-Simon Möller
2013-08-29 18:11 ` H. Peter Anvin [this message]
2013-08-29 18:11 ` Jan-Simon Möller
2013-08-29 18:18 ` H. Peter Anvin
2013-08-29 18:23 ` Jan-Simon Möller
2013-08-29 18:31 ` H. Peter Anvin
2013-08-29 18:36 ` Jan-Simon Möller
2013-08-29 18:41 ` H. Peter Anvin
2013-08-29 19:13 ` dl9pf
2013-08-29 19:13 ` [PATCH 1/2] Extend definitions of _ASM_* with a raw format dl9pf
2013-08-29 20:30 ` [tip:x86/asm] x86, asm: " tip-bot for Jan-Simon Möller
2013-08-29 19:13 ` [PATCH 2/2] [X86] Fix a compilation issue with clang dl9pf
2013-08-29 20:31 ` [tip:x86/asm] x86, asm: " tip-bot for Jan-Simon Möller
2013-08-29 20:42 ` [tip:x86/asm] x86, doc: Update uaccess.h comment to reflect clang changes tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F8ED4.2080009@zytor.com \
--to=hpa@zytor.com \
--cc=dl9pf@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=llvmlinux@lists.linuxfoundation.org \
--cc=pageexec@freemail.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox