From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757186Ab3H2Sl7 (ORCPT ); Thu, 29 Aug 2013 14:41:59 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40818 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756884Ab3H2Sl5 (ORCPT ); Thu, 29 Aug 2013 14:41:57 -0400 Message-ID: <521F95CA.4000905@zytor.com> Date: Thu, 29 Aug 2013 11:41:14 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Jan-Simon_M=F6ller?= CC: llvmlinux@lists.linuxfoundation.org, pageexec@freemail.hu, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue with clang. References: <1377796428-12719-1-git-send-email-dl9pf@gmx.de> <2571698.tomcdIIDB2@aragorn.auenland.lan> <521F9390.9030409@zytor.com> <1563930.LeGpPqNO9R@aragorn.auenland.lan> In-Reply-To: <1563930.LeGpPqNO9R@aragorn.auenland.lan> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2013 11:36 AM, Jan-Simon Möller wrote: > On Thursday 29 August 2013 11:31:44 H. Peter Anvin wrote: >> On 08/29/2013 11:23 AM, Jan-Simon Möller wrote: >>>> Actually, it might be a bad idea. In C embedded assembly we sometimes >>>> need %% and sometimes %. >>> >>> You speak of arch/x86/kvm/vmx.c, right ? >> >> Well, in general. > > Ok, I see. So back to the patch - can we merge it then ? > Please split it in two: one for the changes to the _ASM_* macros (and explain why it matters) and one for the actual change. -hpa