From: Chen Gang <gang.chen@asianux.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling
Date: Fri, 30 Aug 2013 11:54:38 +0800 [thread overview]
Message-ID: <5220177E.709@asianux.com> (raw)
In-Reply-To: <521B2E75.1040802@asianux.com>
On 08/26/2013 06:31 PM, Chen Gang wrote:
> Need add "linux/initrd.h" to pass compiling.
>
> The related error (allmodconfig for h8300):
>
> arch/h8300/kernel/setup.c: In function 'setup_arch':
> arch/h8300/kernel/setup.c:103:3: error: 'initrd_start' undeclared (first use in this function)
> initrd_start = memory_start;
> ^
> arch/h8300/kernel/setup.c:103:3: note: each undeclared identifier is reported only once for each function it appears in
> arch/h8300/kernel/setup.c:104:3: error: 'initrd_end' undeclared (first use in this function)
> initrd_end = memory_start += be32_to_cpu(((unsigned long *) (memory_start))[2]);
> ^
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/h8300/kernel/setup.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index d0b1607..684e734 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -47,6 +47,9 @@
> #include <asm/regs267x.h>
> #endif
>
> +#if defined(CONFIG_BLK_DEV_INITRD)
> +#include <linux/initrd.h>
> +#endif
> #define STUBSIZE 0xc000
>
Oh, it need an empty line after "#endif" to mach "current coding style".
I will send patch v2 for it.
Thanks.
> unsigned long rom_length;
>
--
Chen Gang
next prev parent reply other threads:[~2013-08-30 3:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 10:31 [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling Chen Gang
2013-08-26 11:00 ` Geert Uytterhoeven
2013-08-26 11:06 ` Chen Gang
2013-08-26 11:08 ` Geert Uytterhoeven
2013-08-26 11:19 ` Chen Gang
2013-08-26 22:12 ` Guenter Roeck
2013-08-27 1:58 ` Chen Gang
2013-08-30 3:54 ` Chen Gang [this message]
2013-08-30 3:59 ` [PATCH v2] " Chen Gang
2013-08-30 4:32 ` Guenter Roeck
2013-08-30 5:49 ` Chen Gang
2013-08-30 11:12 ` Guenter Roeck
2013-09-02 2:51 ` Chen Gang
2013-08-30 4:53 ` Guenter Roeck
2013-08-30 6:34 ` Chen Gang
2013-08-30 11:18 ` Guenter Roeck
2013-08-30 11:44 ` richard -rw- weinberger
2013-08-30 12:20 ` Guenter Roeck
2013-09-02 3:26 ` Chen Gang
2013-09-03 8:29 ` [PATCH trivial] block/ioctl.c: let code match 'kernel code style' Chen Gang
2013-09-03 8:55 ` Li Zefan
2013-09-03 9:06 ` Chen Gang
2013-09-03 9:27 ` Jiri Kosina
2013-09-03 9:58 ` Chen Gang
2013-09-03 9:54 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220177E.709@asianux.com \
--to=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox