From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288Ab3H3JNu (ORCPT ); Fri, 30 Aug 2013 05:13:50 -0400 Received: from intranet.asianux.com ([58.214.24.6]:25640 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754Ab3H3JNs (ORCPT ); Fri, 30 Aug 2013 05:13:48 -0400 X-Spam-Score: -100.9 Message-ID: <52206202.8050001@asianux.com> Date: Fri, 30 Aug 2013 17:12:34 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Yoshinori Sato , Arnd Bergmann , "dhowells@redhat.com" , Dave Jones , David Sharp , "linux-kernel@vger.kernel.org" , Rusty Russell Subject: Re: [PATCH] h8300: include: asm: Kbuild: add gpio.h for pass compiling References: <521B2AF7.6070806@asianux.com> <521B3514.305@asianux.com> <521C26FA.8050208@asianux.com> In-Reply-To: <521C26FA.8050208@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2013 12:11 PM, Chen Gang wrote: > On 08/26/2013 06:59 PM, Chen Gang wrote: >> On 08/26/2013 06:21 PM, Geert Uytterhoeven wrote: >>> On Mon, Aug 26, 2013 at 12:16 PM, Chen Gang wrote: >>>> Need add default "gpio.h" for h8300, or can not pass compiling. >>>> >>>> The related error (allmodconfig for h8300): >>>> >>>> arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory >>>> #include >>>> ^ >>> >>> I this include needed at all? Perhaps it can just be removed? >>> >> >> Pardon ? Do you mean, only removing it will be OK ? >> >>>> Signed-off-by: Chen Gang >>>> --- >>>> arch/h8300/include/asm/Kbuild | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild >>>> index 8ada3cf..4c627aa 100644 >>>> --- a/arch/h8300/include/asm/Kbuild >>>> +++ b/arch/h8300/include/asm/Kbuild >>>> @@ -1,6 +1,7 @@ >>>> >>>> generic-y += clkdev.h >>>> generic-y += exec.h >>>> +generic-y += gpio.h >>>> generic-y += linkage.h >>>> generic-y += mmu.h >>>> generic-y += module.h >>> >>> The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are: >>> >>> EXPORT_SYMBOL(h8300_reserved_gpio); >>> EXPORT_SYMBOL(h8300_free_gpio); >>> EXPORT_SYMBOL(h8300_set_gpio_dir); >>> >>> and these are definitely not provided by asm-generic/gpio.h. >>> >> >> Yeah, I will try to remove "#include " to see whether can >> pass compiling, tomorrow. :-) >> >> And now, I feel (just guess), it will not, for h8300 really need gpio >> (it has "gpio-internal.h"), commonly it will need "asm/gpio.h" too. >> >> Tomorrow, I will try to prove whether my guess is correct or not. ;-). >> > > After reading the related code (search "gpio.h" in root source tree), > it seems what you said is correct, my guess is incorrect. :-( > > Hmm... but better to get final conclusion after finish allmodconfig > compiling. > > Now, I am compiling, and excuse me, I can not finish today because of > some issues (mainly for 'gcc 4.8.0', part for 'ld 2.22', and part for > kernel), I will 'process' them, hope can finish before 2013-08-31. > Oh, sorry, I can not finish allmodconfig today, I have to delay the schedule. The excuse is "it is too many issues (both for h8000 and for other sub systems) than I guessed originally". I should try to finish it within next week (2013-09-06). BTW: I disable the '-Os' for allmodconfig under h8300, or gcc will cause many various bugs (disable '-Os' doesn't matter with our goal, and I will continue for gcc issues with gcc guys, next). Thanks. > > Welcome additional suggestions or completions. > > Thanks. > >> >> Thanks. >> >>> Gr{oetje,eeting}s, >>> >>> Geert >>> >>> -- >>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org >>> >>> In personal conversations with technical people, I call myself a hacker. But >>> when I'm talking to journalists I just say "programmer" or something like that. >>> -- Linus Torvalds >>> >>> >> >> > > -- Chen Gang