From: Luca Weiss <luca@z3ntu.xyz>
To: linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht, bartosz.dudziak@snejp.pl,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Sam Ravnborg <sam@ravnborg.org>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Palmer <daniel@0x0f.com>,
Max Merchel <Max.Merchel@tq-group.com>,
Hao Fang <fanghao11@huawei.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics
Date: Mon, 13 Sep 2021 21:14:14 +0200 [thread overview]
Message-ID: <5220943.AHGTne7y6d@g550jk> (raw)
In-Reply-To: <9942f964-442e-e782-3926-6d7d1123418a@canonical.com>
Hi Krzysztof,
On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote:
> On 12/09/2021 01:27, Luca Weiss wrote:
> > LG Electronics is a part of the LG Corporation and produces, amongst
> > other things, consumer electronics such as phones and smartwatches.
>
> Hi,
>
> Thanks for the patches.
>
> I think "lge" it's the same prefix as "lg". There is no sense in having
> multiple vendor prefixes just because company splits inside business
> units or subsidiaries. The same as with other conglomerates, e.g.
> Samsung - if we wanted to be specific, there will be 4-5 Samsung
> vendors... Not mentioning that company organisation is not always
> disclosed and can change.
>
I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the other LG
device tree I am aware of so I've picked lge instead of lg. Also worth noting
that Google uses "LGE" in the Android device tree[1] or in the model name in
the LG G Watch R kernel sources ("LGE APQ 8026v2 LENOK rev-1.0").
I don't have a strong opinion either way so I'm fine with either.
If we decide to go with "lg" do we want to change the Nexus 5 devicetree
(hammerhead) also, that one has the lge name in at least compatible and
filename (I don't know how much of a breaking change that would be considered
as).
> We already have lg for several components, also made by LG Electronics.
> What about these?
>
> There is only one device with "lge", added back in 2016 without adding
> vendor prefix. I would propose to fix that one, instead of keeping
> duplicated "lg".
>
> Best regards,
> Krzysztof
Regards
Luca
[1] https://android.googlesource.com/device/lge/hammerhead/
next prev parent reply other threads:[~2021-09-13 19:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 23:26 [PATCH 0/8] Initial LG G Watch R support Luca Weiss
2021-09-11 23:26 ` [PATCH 1/8] pinctrl: qcom: msm8226: fill in more functions Luca Weiss
2021-09-13 17:45 ` Bjorn Andersson
2021-09-17 22:31 ` Linus Walleij
2021-09-11 23:26 ` [PATCH 2/8] dt-bindings: mmc: sdhci-msm: Add compatible string for msm8226 Luca Weiss
2021-09-14 11:24 ` Ulf Hansson
2021-09-11 23:26 ` [PATCH 3/8] dt-bindings: firmware: scm: Add compatible " Luca Weiss
2021-09-11 23:26 ` [PATCH 4/8] ARM: dts: qcom: msm8226: Add more SoC bits Luca Weiss
2021-09-11 23:26 ` [PATCH 5/8] ARM: dts: qcom: Add pm8226 PMIC Luca Weiss
2021-09-11 23:27 ` [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics Luca Weiss
2021-09-13 8:49 ` Krzysztof Kozlowski
2021-09-13 19:14 ` Luca Weiss [this message]
2021-09-14 7:24 ` Krzysztof Kozlowski
2022-01-27 0:20 ` Petr Vorel
2022-01-27 7:45 ` Krzysztof Kozlowski
2022-01-27 20:51 ` Luca Weiss
2022-01-28 9:57 ` Krzysztof Kozlowski
2022-01-29 9:45 ` Luca Weiss
2022-01-29 10:34 ` Krzysztof Kozlowski
2021-09-11 23:27 ` [PATCH 7/8] dt-bindings: arm: qcom: Document APQ8026 SoC binding Luca Weiss
2021-09-20 21:53 ` Rob Herring
2021-09-11 23:27 ` [PATCH 8/8] ARM: dts: qcom: Add support for LG G Watch R Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220943.AHGTne7y6d@g550jk \
--to=luca@z3ntu.xyz \
--cc=Max.Merchel@tq-group.com \
--cc=bartosz.dudziak@snejp.pl \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=fanghao11@huawei.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox