public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] xtensa: Fix broken allmodconfig build
Date: Mon, 02 Sep 2013 19:55:30 -0700	[thread overview]
Message-ID: <52254FA2.8020407@roeck-us.net> (raw)
In-Reply-To: <1377662797-21770-1-git-send-email-linux@roeck-us.net>

On 08/27/2013 09:06 PM, Guenter Roeck wrote:
> xtansa allmodbuild fails with:
>
> arch/xtensa/kernel/xtensa_ksyms.c:129:1: error: '_mcount' undeclared here (not in a function)
> make[2]: *** [arch/xtensa/kernel/xtensa_ksyms.o] Error 1
> make[1]: *** [arch/xtensa/kernel] Error 2
>
> The breakage is due to commit 478ba61af (xtensa: add static function tracer
> support) which exports _mcount without declaring it.
>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Ping ... 3.11 now ships with xtensa allmodconfig broken, which is completely unnecessary.

Guenter

>   arch/xtensa/kernel/xtensa_ksyms.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
> index d8507f8..74a60c7 100644
> --- a/arch/xtensa/kernel/xtensa_ksyms.c
> +++ b/arch/xtensa/kernel/xtensa_ksyms.c
> @@ -25,6 +25,7 @@
>   #include <asm/io.h>
>   #include <asm/page.h>
>   #include <asm/pgalloc.h>
> +#include <asm/ftrace.h>
>   #ifdef CONFIG_BLK_DEV_FD
>   #include <asm/floppy.h>
>   #endif
>


  parent reply	other threads:[~2013-09-03  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  4:06 [PATCH] xtensa: Fix broken allmodconfig build Guenter Roeck
2013-08-28  4:11 ` Guenter Roeck
2013-09-03  2:55 ` Guenter Roeck [this message]
2013-09-06 17:48   ` Chris Zankel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52254FA2.8020407@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=chris@zankel.net \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox