From: Stephen Warren <swarren@wwwdotorg.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Tomasz Figa <tomasz.figa@gmail.com>,
Dave Martin <Dave.Martin@arm.com>,
gnurou@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] ARM: add basic Trusted Foundations support
Date: Tue, 03 Sep 2013 12:40:20 -0600 [thread overview]
Message-ID: <52262D14.4000907@wwwdotorg.org> (raw)
In-Reply-To: <1377770268-14014-2-git-send-email-acourbot@nvidia.com>
On 08/29/2013 03:57 AM, Alexandre Courbot wrote:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using a consistent smc-based API on all supported
Nit: s/smc/SMC/?
> diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
> +#if IS_ENABLED(CONFIG_TRUSTED_FOUNDATIONS)
> +
> +void register_trusted_foundations(struct trusted_foundations_platform_data *pd);
> +void of_register_trusted_foundations(void);
> +
> +#else
> +
> +static inline void register_trusted_foundations(
> + struct trusted_foundations_platform_data *pd)
> +{
> + pr_crit("No support for Trusted Foundations, stopping...\n");
> + BUG();
> +}
> +
> +static inline void of_register_trusted_foundations(void)
> +{
> + register_trusted_foundations(NULL);
That will cause a hard-fail. I assume that should only happen if the TL
DT node is present; if there's no DT node, it's fine for a kernel
without any TL support to run.
> +}
> +
> +#endif /* IS_ENABLED(CONFIG_TRUSTED_FOUNDATIONS) */
next prev parent reply other threads:[~2013-09-03 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 9:57 [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations Alexandre Courbot
2013-08-29 9:57 ` [PATCH v4 1/5] ARM: add basic Trusted Foundations support Alexandre Courbot
2013-08-30 8:20 ` Tomasz Figa
2013-09-02 7:28 ` Alexandre Courbot
2013-09-03 18:36 ` Stephen Warren
2013-09-03 18:40 ` Stephen Warren [this message]
2013-08-29 9:57 ` [PATCH v4 2/5] ARM: tegra: add support for Trusted Foundations Alexandre Courbot
2013-08-29 9:57 ` [PATCH v4 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-08-29 9:57 ` [PATCH v4 4/5] ARM: tegra: set CPU reset handler with firmware op Alexandre Courbot
2013-08-29 9:57 ` [PATCH v4 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot
2013-08-30 8:23 ` [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations Tomasz Figa
2013-09-03 18:42 ` Stephen Warren
2013-09-04 2:31 ` Alex Courbot
2013-09-04 18:25 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52262D14.4000907@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Dave.Martin@arm.com \
--cc=acourbot@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox