Re: [PATCH v2 0/8] Drop support for Renesas H8/300 architecture

Guenter Roeck
2013-09-03T03:26:20Z

On 09/02/2013 07:53 PM, Chen Gang F T wrote:
> Hello Guenter Roeck:
>
>
> I don't care about whether I am in cc mailing list, but at least,
> please help confirm 2 things:
>
> Is what I had done for h8300 just making wastes and noisy in kernel and related sub-system mailing list ?
>
> and is the disccusion about h8300 between us also wastes and noisy in kernel mailing list ?
>

It raised my awareness of the status of h8300 maintenance,
so I would not see it as noise or waste. I might have suggested
a different target for your efforts, but that is your choice to make,
not mine.

On the code review side, I had suggested that you should not add new
ifdefs into code, much less unnecessary ones. Your counter-argument
was that you wanted to follow the existing coding style in the file
in question. To me, that argument is along the line of "the coding
style in this file is bad, let's do more of it".
That doesn't make much sense to me, so I did not bother to respond.
Setting that aside, it is not up to me to approve or reject your patches.
Whoever does that would be the one you have to convince.

Guenter