From: Guenter Roeck <linux@roeck-us.net>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Thomas.Mingarelli@hp.com" <Thomas.Mingarelli@hp.com>,
"toshi.kani@hp.com" <toshi.kani@hp.com>,
"wim@iguana.be" <wim@iguana.be>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH 1/2] Move and rename HP watchdog timer driver
Date: Tue, 03 Sep 2013 22:56:58 -0700 [thread overview]
Message-ID: <5226CBAA.10002@roeck-us.net> (raw)
In-Reply-To: <1378273901.11730.53.camel@x230>
On 09/03/2013 10:51 PM, Matthew Garrett wrote:
> On Tue, 2013-09-03 at 22:43 -0700, Guenter Roeck wrote:
>
>> If that is the case, wouldn't it make more sense to have separate drivers,
>> one per functionality, plus an mfd driver to bind them all together ?
>
> It'd be an option, but I don't think there's a huge benefit - the
> functionality's reasonably related and there's no real internal bus
> architecture on the device.
>
On the other side it is much cleaner. drivers/mfd/lpc_sch.c and drivers/mfd/lpc_ich.c
are good examples.
Guenter
prev parent reply other threads:[~2013-09-04 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 5:29 [PATCH 1/2] Move and rename HP watchdog timer driver Matthew Garrett
2013-09-04 5:29 ` [PATCH 2/2] Add support for modifying firmware configuration via HP iLO Matthew Garrett
2013-09-04 5:43 ` [PATCH 1/2] Move and rename HP watchdog timer driver Guenter Roeck
2013-09-04 5:51 ` Matthew Garrett
2013-09-04 5:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226CBAA.10002@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Thomas.Mingarelli@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=toshi.kani@hp.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox