* [PATCH] UBI: fix refill_wl_user_pool()
@ 2013-08-26 10:08 Richard Weinberger
2013-09-04 8:20 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2013-08-26 10:08 UTC (permalink / raw)
To: dedekind1
Cc: dwmw2, linux-mtd, linux-kernel, richard.genoud,
Richard Weinberger
If no free PEBs are available refill_wl_user_pool() must not
return with -ENOSPC immediately.
It has to block till produce_free_peb() produced a free PEB.
Reported-and-Tested-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/wl.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index c95bfb1..02317c1 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -599,10 +599,6 @@ static void refill_wl_user_pool(struct ubi_device *ubi)
return_unused_pool_pebs(ubi, pool);
for (pool->size = 0; pool->size < pool->max_size; pool->size++) {
- if (!ubi->free.rb_node ||
- (ubi->free_count - ubi->beb_rsvd_pebs < 1))
- break;
-
pool->pebs[pool->size] = __wl_get_peb(ubi);
if (pool->pebs[pool->size] < 0)
break;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UBI: fix refill_wl_user_pool()
2013-08-26 10:08 [PATCH] UBI: fix refill_wl_user_pool() Richard Weinberger
@ 2013-09-04 8:20 ` Richard Weinberger
2013-09-20 16:09 ` richard -rw- weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2013-09-04 8:20 UTC (permalink / raw)
To: Richard Weinberger
Cc: dedekind1, dwmw2, linux-mtd, linux-kernel, richard.genoud
Am 26.08.2013 12:08, schrieb Richard Weinberger:
> If no free PEBs are available refill_wl_user_pool() must not
> return with -ENOSPC immediately.
> It has to block till produce_free_peb() produced a free PEB.
>
> Reported-and-Tested-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/ubi/wl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index c95bfb1..02317c1 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -599,10 +599,6 @@ static void refill_wl_user_pool(struct ubi_device *ubi)
> return_unused_pool_pebs(ubi, pool);
>
> for (pool->size = 0; pool->size < pool->max_size; pool->size++) {
> - if (!ubi->free.rb_node ||
> - (ubi->free_count - ubi->beb_rsvd_pebs < 1))
> - break;
> -
> pool->pebs[pool->size] = __wl_get_peb(ubi);
> if (pool->pebs[pool->size] < 0)
> break;
>
Artem, please don't forget do apply this patch.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UBI: fix refill_wl_user_pool()
2013-09-04 8:20 ` Richard Weinberger
@ 2013-09-20 16:09 ` richard -rw- weinberger
0 siblings, 0 replies; 3+ messages in thread
From: richard -rw- weinberger @ 2013-09-20 16:09 UTC (permalink / raw)
To: Richard Weinberger
Cc: richard.genoud, linux-mtd@lists.infradead.org, David Woodhouse,
LKML, Artem Bityutskiy
On Wed, Sep 4, 2013 at 10:20 AM, Richard Weinberger <richard@nod.at> wrote:
> Am 26.08.2013 12:08, schrieb Richard Weinberger:
>> If no free PEBs are available refill_wl_user_pool() must not
>> return with -ENOSPC immediately.
>> It has to block till produce_free_peb() produced a free PEB.
>>
>> Reported-and-Tested-by: Richard Genoud <richard.genoud@gmail.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/ubi/wl.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
>> index c95bfb1..02317c1 100644
>> --- a/drivers/mtd/ubi/wl.c
>> +++ b/drivers/mtd/ubi/wl.c
>> @@ -599,10 +599,6 @@ static void refill_wl_user_pool(struct ubi_device *ubi)
>> return_unused_pool_pebs(ubi, pool);
>>
>> for (pool->size = 0; pool->size < pool->max_size; pool->size++) {
>> - if (!ubi->free.rb_node ||
>> - (ubi->free_count - ubi->beb_rsvd_pebs < 1))
>> - break;
>> -
>> pool->pebs[pool->size] = __wl_get_peb(ubi);
>> if (pool->pebs[pool->size] < 0)
>> break;
>>
>
> Artem, please don't forget do apply this patch.
*ping*
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-20 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 10:08 [PATCH] UBI: fix refill_wl_user_pool() Richard Weinberger
2013-09-04 8:20 ` Richard Weinberger
2013-09-20 16:09 ` richard -rw- weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox