From: Stephen Warren <swarren@wwwdotorg.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, pbonzini@redhat.com,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [GIT PULL] KVM changes for 3.12
Date: Wed, 04 Sep 2013 12:12:01 -0600 [thread overview]
Message-ID: <522777F1.50502@wwwdotorg.org> (raw)
In-Reply-To: <20130904103855.GC7402@redhat.com>
On 09/04/2013 04:38 AM, Gleb Natapov wrote:
> Copying Marek, Aneesh and Alex since this came through PPC kvm tree.
>
> On Wed, Sep 04, 2013 at 12:18:28PM +0200, Thierry Reding wrote:
>> On Tue, Sep 03, 2013 at 03:10:46PM +0300, Gleb Natapov wrote:
>> [...]
>>> Aneesh Kumar K.V (5):
>>> mm/cma: Move dma contiguous changes into a seperate config
>>
>> Hi Gleb,
>>
>> This commit is going to cause runtime regressions on various ARM
>> platforms because it renames a symbol but fails to update all default
>> configurations that select the symbol. A quick grep shows that three ARM
>> platforms are affected:
>>
>> $ git grep CONFIG_CMA=y
>> arch/arm/configs/keystone_defconfig:CONFIG_CMA=y
>> arch/arm/configs/omap2plus_defconfig:CONFIG_CMA=y
>> arch/arm/configs/tegra_defconfig:CONFIG_CMA=y
>>
>> I've been digging around a bit and it seems like the original patch from
>> Aneesh had the defconfig changes but they were dropped because they "...
>> require separate handling to avoid pointless merge conflicts."[0]
>>
> Marek, that's your words. What do you think about ARM problem?
>
>> While I can't speak for Keystone or OMAP, at least on Tegra this causes
>> issues because we use CMA for framebuffer allocation. Since we only have
>> CMA selected but not the new DMA_CMA, large DMA allocations will fail.
>>
> Make config suppose to ask you about new option though, does it?
"make oldconfig" quite possibly might, but "make tegra_defconfig"
doesn't, and "make tegra_defconfig; make zImage" is a workflow that has
historically generated a perfectly working kernel for Tegra, and hence
people use that flow.
next prev parent reply other threads:[~2013-09-04 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 12:10 [GIT PULL] KVM changes for 3.12 Gleb Natapov
2013-09-04 10:18 ` Thierry Reding
2013-09-04 10:38 ` Gleb Natapov
2013-09-04 18:12 ` Stephen Warren [this message]
2013-09-05 1:08 ` Linus Torvalds
2013-09-05 5:53 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522777F1.50502@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pbonzini@redhat.com \
--cc=thierry.reding@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox