Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT

Lee Jones
2013-09-04T13:37:03Z

On Wed, 04 Sep 2013, Mark Rutland wrote:

> Hi Lee,
>
> On Wed, Sep 04, 2013 at 10:31:34AM +0100, Lee Jones wrote:
> > After applying this node the LPS001WP sensor chip should probe
> > successfully once the driver support has also been applied.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> > index cf9b16e..aad8f54 100644
> > --- a/arch/arm/boot/dts/ste-snowball.dts
> > +++ b/arch/arm/boot/dts/ste-snowball.dts
> > @@ -153,6 +153,16 @@
> > status = "okay";
> > };
> >
> > + i2c@80128000 {
> > + lps001wp@5c {
> > + compatible = "lps001wp";
> > + reg = <0x5c>;
> > +
> > + vdd-supply = <&ab8500_ldo_aux1_reg>;
> > + vms-supply = <&db8500_vsmps2_reg>;
> > + };
> > + };
> > +
>
> This appears to be missing a binding document. I couldn't see one
> anywhere in this series, or in mainline already).
>
> As far as I can see, the compatible string should be "st,lps001wp".

The I2C subsystem doesn't actually care about vendor prefixes. They
are all stripped before use in all cases. However, I'm happy to
provide one if for no other reason than to stick to convention.

> Please produce a binding document.

Again, I'm happy to provide a boilerplate document, but there's
nothing special happening here.

> Is there any publicly available documentation on the chip?

If you Google the device name, it will be the first hit.

> > uart@80120000 {
> > status = "okay";
> > };

Kind regards,
Lee

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog