From: Michal Marek <mmarek@suse.cz>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol
Date: Thu, 05 Sep 2013 11:38:20 +0200 [thread overview]
Message-ID: <5228510C.1020906@suse.cz> (raw)
In-Reply-To: <1378242287-12759-1-git-send-email-yann.morin.1998@free.fr>
On 3.9.2013 23:04, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Currently, the 'MODULES' symbol is hard-coded to be the default symbol
> that enables/disables tristates, if no other symbol was declared with
> 'option modules'.
>
> While this used to be needed for the Linux kernel, we now have an
> explicit 'option modules' attached to the 'MODULES' symbol (since
> cset 11097a036), so we no longer need to special-case it in the
> kconfig code.
>
> Furthermore, kconfig is extensively used out of the Linux kernel, and
> other projects may have another meaning for a symbol named 'MODULES'.
>
> This patch changes the way we enable/disable tristates: if a symbol was
> found with 'option modules' attached to it, then that symbol controls
> enabling tristates. Otherwise, tristates are disabled, even if a symbol
> named 'MODULES' exists.
Wasn't this change supposed to fix allmodconfig with KCONFIG_ALLCONFIG
(http://lkml.org/lkml/2013/8/8/573)? Or is there still more to do?
Because I'm still getting:
$ touch empty
$ make KCONFIG_ALLCONFIG=empty allmodconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
$ grep MODULES .config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set
$
Michal
next prev parent reply other threads:[~2013-09-05 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 21:04 [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol Yann E. MORIN
2013-09-03 21:04 ` [PATCH 2/3] kconfig: regenerate bison parser Yann E. MORIN
2013-09-03 21:04 ` [PATCH 3/3] kconfig: do not allow more than one symbol to have 'option modules' Yann E. MORIN
2013-09-03 21:12 ` [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol Yann E. MORIN
2013-09-04 8:22 ` Michal Marek
2013-09-05 9:38 ` Michal Marek [this message]
2013-09-05 10:02 ` Michal Marek
2013-09-06 9:48 ` Yann E. MORIN
2013-09-06 9:47 ` Yann E. MORIN
2013-09-06 10:02 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 10:59 [pull request] Pull request for branch yem/kconfig-for-next Yann E. MORIN
2013-09-04 10:59 ` [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5228510C.1020906@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox