* [PATCH] staging: dgnc: driver.c: casting (void *)value returned by kzalloc is useless
@ 2013-09-05 10:31 Duan Jiong
2013-09-25 23:04 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2013-09-05 10:31 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index f8c1e22..ac64181 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -499,7 +499,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
/* get the board structure and prep it */
brd = dgnc_Board[dgnc_NumBoards] =
- (struct board_t *) kzalloc(sizeof(struct board_t), GFP_KERNEL);
+ kzalloc(sizeof(struct board_t), GFP_KERNEL);
if (!brd) {
APR(("memory allocation for board structure failed\n"));
return(-ENOMEM);
@@ -507,7 +507,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
/* make a temporary message buffer for the boot messages */
brd->msgbuf = brd->msgbuf_head =
- (char *) kzalloc(sizeof(char) * 8192, GFP_KERNEL);
+ kzalloc(sizeof(char) * 8192, GFP_KERNEL);
if (!brd->msgbuf) {
kfree(brd);
APR(("memory allocation for board msgbuf failed\n"));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: dgnc: driver.c: casting (void *)value returned by kzalloc is useless
2013-09-05 10:31 [PATCH] staging: dgnc: driver.c: casting (void *)value returned by kzalloc is useless Duan Jiong
@ 2013-09-25 23:04 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-09-25 23:04 UTC (permalink / raw)
To: Duan Jiong; +Cc: linux-kernel
On Thu, Sep 05, 2013 at 06:31:39PM +0800, Duan Jiong wrote:
> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
>
> Casting (void *) value returned by kzalloc is useless
> as mentioned in Documentation/CodingStyle, Chap 14.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
No longer applies, please redo against the latest linux-next release.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-25 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 10:31 [PATCH] staging: dgnc: driver.c: casting (void *)value returned by kzalloc is useless Duan Jiong
2013-09-25 23:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox