Re: [PATCH] mfd: rtsx: Modify rts5249_optimize_phy

[wwang <wei_wang@realsil.com.cn>]

于 2013年09月05日 18:48, Dan Carpenter 写道:
> On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_wang@realsil.com.cn wrote:
>> From: Wei WANG <wei_wang@realsil.com.cn>
>>
>> In some platforms, specially Thinkpad series, rts5249 won't be
>> initialized properly. So we need adjust some phy parameters to
>> improve the compatibility issue.
>>
>> Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
>> ---
>>   drivers/mfd/rts5249.c |   25 +++++++++++++++++++++++--
>>   1 file changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
>> index 3b835f5..e3c6dc1 100644
>> --- a/drivers/mfd/rts5249.c
>> +++ b/drivers/mfd/rts5249.c
>> @@ -130,13 +130,34 @@ static int rts5249_optimize_phy(struct rtsx_pcr *pcr)
>>   {
>>   	int err;
>>   
>> -	err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, 0xFE46);
>> +	err = rtsx_pci_write_phy_register(pcr, PHY_REG_REV, 0xFC6C);
>
> How are we supposed to review this change?  What happened to 0xFE46?
> What are all these magic numbers?  I understand that this fixes an issue
> for think pads but does it break something else?
>
> regards,
> dan carpenter
>
> .
>
Hi Dan:

These numbers are used to configure the parameters of our internal 
analog circuit. Those new values have been tested for quite a long time 
with our Windows driver. So it's guaranteed and won't break other platforms.

BR,
Wei