public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xie XiuQi <xiexiuqi@huawei.com>
To: Jonathan Cameron <jic23@cam.ac.uk>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dmitry Torokhov <dtor@mail.ru>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andres Salomon <dilinger@queued.net>, Chris Ball <cjb@laptop.org>,
	Jon Nettleton <jon.nettleton@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nadia Derbey <Nadia.Derbey@bull.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Li Bin <huawei.libin@huawei.com>, Tejun Heo <tj@kernel.org>
Subject: [PATCH 1/5] iio: adc: remove unnecessary work pending test
Date: Fri, 6 Sep 2013 19:02:34 +0800	[thread overview]
Message-ID: <5229B64A.1030304@huawei.com> (raw)
In-Reply-To: <5229B601.9090109@huawei.com>

Remove unnecessary work pending test before calling schedule_work().
It has been tested in queue_work_on() already. No functional changed.

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Cc: Tejun Heo <tj@kernel.org>
---
 drivers/staging/iio/adc/ad7606_core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7606_core.c b/drivers/staging/iio/adc/ad7606_core.c
index 72868ce..c6f99069 100644
--- a/drivers/staging/iio/adc/ad7606_core.c
+++ b/drivers/staging/iio/adc/ad7606_core.c
@@ -424,10 +424,9 @@ static irqreturn_t ad7606_interrupt(int irq, void *dev_id)
 	struct iio_dev *indio_dev = dev_id;
 	struct ad7606_state *st = iio_priv(indio_dev);

-	if (iio_buffer_enabled(indio_dev)) {
-		if (!work_pending(&st->poll_work))
-			schedule_work(&st->poll_work);
-	} else {
+	if (iio_buffer_enabled(indio_dev))
+		schedule_work(&st->poll_work);
+	else {
 		st->done = true;
 		wake_up_interruptible(&st->wq_data_avail);
 	}
-- 
1.8.2.2




  reply	other threads:[~2013-09-06 11:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 11:01 [PATCH 0/5] remove unnecessary work pending test Xie XiuQi
2013-09-06 11:02 ` Xie XiuQi [this message]
2013-09-06 15:20   ` [PATCH 1/5] iio: adc: " Tejun Heo
2013-09-07 20:44     ` Jonathan Cameron
     [not found]       ` <522DE7F4.1050202@analog.com>
2013-09-09 21:14         ` Jonathan Cameron
2013-09-06 11:03 ` [PATCH 2/5] input: " Xie XiuQi
2013-09-06 15:21   ` Tejun Heo
2013-09-06 11:05 ` [PATCH 3/5] lib: " Xie XiuQi
2013-09-06 15:22   ` Tejun Heo
2013-09-06 11:06 ` [PATCH 4/5] staging: olpc_dcon: " Xie XiuQi
2013-09-06 15:24   ` Tejun Heo
2013-09-06 11:07 ` [PATCH 5/5] ipc: " Xie XiuQi
2013-09-06 15:25   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5229B64A.1030304@huawei.com \
    --to=xiexiuqi@huawei.com \
    --cc=Nadia.Derbey@bull.net \
    --cc=akpm@linux-foundation.org \
    --cc=cjb@laptop.org \
    --cc=dilinger@queued.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@mail.ru \
    --cc=huawei.libin@huawei.com \
    --cc=jic23@cam.ac.uk \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox