From: John Garry <john.garry@huawei.com>
To: James Smart <james.smart@broadcom.com>,
Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
<dick.kennedy@broadcom.com>, <jejb@linux.vnet.ibm.com>,
<martin.petersen@oracle.com>
Cc: <jrdr.linux@gmail.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <brajeswar.linux@gmail.com>
Subject: Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent
Date: Wed, 21 Nov 2018 07:56:24 +0000 [thread overview]
Message-ID: <5229ccbb-e6de-e114-52fb-235ea703a7ef@huawei.com> (raw)
In-Reply-To: <34556d50-562b-43b2-873f-ba68056e5af5@broadcom.com>
On 20/11/2018 21:52, James Smart wrote:
> On 11/20/2018 1:40 AM, John Garry wrote:
>>
>> please ensure that you maintain alignment with opening brackets
>
> I don't think this is a requirement. From the rules I've read
> preference is tabs-only indentation.
This is the only rule (enforcement) I see:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20181120&id=d1fe9c099cecc6e49324355f1b15573e9dbbe0f9
Spacing (less than a tab), after
> tabs, for open brace alignment is allowed, thus is coder's choice.
It seems that alignment was being implemented with tab+space, and now it
would be tab+space but no alignment.
cheers,
John
>
> -- james
>
>
>
>
>
>
>
next prev parent reply other threads:[~2018-11-21 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 14:38 [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-20 9:40 ` John Garry
2018-11-20 21:52 ` James Smart
2018-11-21 7:56 ` John Garry [this message]
2018-11-20 21:53 ` James Smart
2018-11-22 3:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229ccbb-e6de-e114-52fb-235ea703a7ef@huawei.com \
--to=john.garry@huawei.com \
--cc=brajeswar.linux@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox