* [PATCH] simplefb: print some info about the registered fb @ 2013-09-06 11:44 Tom Gundersen 2013-09-06 11:49 ` Tom Gundersen 0 siblings, 1 reply; 9+ messages in thread From: Tom Gundersen @ 2013-09-06 11:44 UTC (permalink / raw) To: linux-fbdev Cc: linux-kernel, tomi.valkeinen, plagnioj, Tom Gundersen, Stephen Warren, David Herrmann This is similar to the output printed by efifb. Signed-off-by: Tom Gundersen <teg@jklm.no> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: David Herrmann <dh.herrmann@gmail.com> --- drivers/video/simplefb.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 8d78106..4196686 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) } info->pseudo_palette = (void *)(info + 1); + dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n", + info->fix.smem_start, info->screen_base); + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", + params.format->name, + info->var.xres, info->var.yres, + info->var.bits_per_pixel, + info->fix.line_length); + ret = register_framebuffer(info); if (ret < 0) { dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); -- 1.8.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] simplefb: print some info about the registered fb 2013-09-06 11:44 [PATCH] simplefb: print some info about the registered fb Tom Gundersen @ 2013-09-06 11:49 ` Tom Gundersen 2013-09-06 19:11 ` Stephen Warren 2013-09-07 11:16 ` David Herrmann 0 siblings, 2 replies; 9+ messages in thread From: Tom Gundersen @ 2013-09-06 11:49 UTC (permalink / raw) To: linux-fbdev Cc: linux-kernel, tomi.valkeinen, plagnioj, Tom Gundersen, Stephen Warren, David Herrmann This is similar to the output printed by efifb. Signed-off-by: Tom Gundersen <teg@jklm.no> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: David Herrmann <dh.herrmann@gmail.com> --- Hi, Sorry for the resend, got the ml address wrong. -t drivers/video/simplefb.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 8d78106..4196686 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) } info->pseudo_palette = (void *)(info + 1); + dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n", + info->fix.smem_start, info->screen_base); + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", + params.format->name, + info->var.xres, info->var.yres, + info->var.bits_per_pixel, + info->fix.line_length); + ret = register_framebuffer(info); if (ret < 0) { dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); -- 1.8.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] simplefb: print some info about the registered fb 2013-09-06 11:49 ` Tom Gundersen @ 2013-09-06 19:11 ` Stephen Warren 2013-09-07 11:16 ` David Herrmann 1 sibling, 0 replies; 9+ messages in thread From: Stephen Warren @ 2013-09-06 19:11 UTC (permalink / raw) To: Tom Gundersen Cc: linux-fbdev, linux-kernel, tomi.valkeinen, plagnioj, David Herrmann On 09/06/2013 05:49 AM, Tom Gundersen wrote: > This is similar to the output printed by efifb. Fine by me, Acked-by: Stephen Warren <swarren@nvidia.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] simplefb: print some info about the registered fb 2013-09-06 11:49 ` Tom Gundersen 2013-09-06 19:11 ` Stephen Warren @ 2013-09-07 11:16 ` David Herrmann 2013-09-07 11:43 ` [PATCH v2] " Tom Gundersen 1 sibling, 1 reply; 9+ messages in thread From: David Herrmann @ 2013-09-07 11:16 UTC (permalink / raw) To: Tom Gundersen Cc: linux-fbdev@vger.kernel.org, linux-kernel, Tomi Valkeinen, Jean-Christophe Plagniol-Villard, Stephen Warren Hi Tom On Fri, Sep 6, 2013 at 1:49 PM, Tom Gundersen <teg@jklm.no> wrote: > This is similar to the output printed by efifb. > > Signed-off-by: Tom Gundersen <teg@jklm.no> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: David Herrmann <dh.herrmann@gmail.com> > --- > > Hi, > > Sorry for the resend, got the ml address wrong. > > -t > > drivers/video/simplefb.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index 8d78106..4196686 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) > } > info->pseudo_palette = (void *)(info + 1); > > + dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n", > + info->fix.smem_start, info->screen_base); Could we get smem_len, too? Something like: dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n", info->fix.smem_start, (unsigned long)info->fix.smem_len, info->screen_base); (smem_len is __u32, so cast it to avoid truncation if it's defined as long somewhere. Not sure whether we actually have 16bit int somewhere, though) Cheers David > + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", > + params.format->name, > + info->var.xres, info->var.yres, > + info->var.bits_per_pixel, > + info->fix.line_length); > + > ret = register_framebuffer(info); > if (ret < 0) { > dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); > -- > 1.8.4 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] simplefb: print some info about the registered fb 2013-09-07 11:16 ` David Herrmann @ 2013-09-07 11:43 ` Tom Gundersen 2013-09-07 13:55 ` Geert Uytterhoeven 0 siblings, 1 reply; 9+ messages in thread From: Tom Gundersen @ 2013-09-07 11:43 UTC (permalink / raw) To: linux-fbdev Cc: linux-kernel, tomi.valkeinen, plagnioj, Tom Gundersen, David Herrmann This is similar to the output printed by efifb. Signed-off-by: Tom Gundersen <teg@jklm.no> Acked-by: Stephen Warren <swarren@wwwdotorg.org> Cc: David Herrmann <dh.herrmann@gmail.com> --- v2: also print smem_len as requested by David drivers/video/simplefb.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 8d78106..80cf074 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) } info->pseudo_palette = (void *)(info + 1); + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n", + info->fix.smem_start, (unsigned long) info->fix.smem_len, + info->screen_base); + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", + params.format->name, + info->var.xres, info->var.yres, + info->var.bits_per_pixel, info->fix.line_length); + ret = register_framebuffer(info); if (ret < 0) { dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); -- 1.8.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] simplefb: print some info about the registered fb 2013-09-07 11:43 ` [PATCH v2] " Tom Gundersen @ 2013-09-07 13:55 ` Geert Uytterhoeven 2013-09-07 14:08 ` [PATCH v3] " Tom Gundersen 0 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2013-09-07 13:55 UTC (permalink / raw) To: Tom Gundersen Cc: Linux Fbdev development list, linux-kernel@vger.kernel.org, Tomi Valkeinen, Jean-Christophe PLAGNIOL-VILLARD, David Herrmann On Sat, Sep 7, 2013 at 1:43 PM, Tom Gundersen <teg@jklm.no> wrote: > + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n", > + info->fix.smem_start, (unsigned long) info->fix.smem_len, Please drop the cast, and use 0x%x. __u32 is unsigned int everywhere (where it matters --- we don't do 16-bit ints). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] simplefb: print some info about the registered fb 2013-09-07 13:55 ` Geert Uytterhoeven @ 2013-09-07 14:08 ` Tom Gundersen 2013-10-01 16:45 ` Tom Gundersen 2013-10-09 9:05 ` Tomi Valkeinen 0 siblings, 2 replies; 9+ messages in thread From: Tom Gundersen @ 2013-09-07 14:08 UTC (permalink / raw) To: linux-fbdev Cc: linux-kernel, tomi.valkeinen, plagnioj, Tom Gundersen, David Herrmann This is similar to the output printed by efifb. Signed-off-by: Tom Gundersen <teg@jklm.no> Acked-by: Stephen Warren <swarren@wwwdotorg.org> Cc: David Herrmann <dh.herrmann@gmail.com> --- v2: also print smem_len, as requested by David v3: don't cast, as requested by Geert drivers/video/simplefb.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index a29f1c4..50cbceb 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) } info->pseudo_palette = (void *)(info + 1); + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n", + info->fix.smem_start, info->fix.smem_len, + info->screen_base); + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", + params.format->name, + info->var.xres, info->var.yres, + info->var.bits_per_pixel, info->fix.line_length); + ret = register_framebuffer(info); if (ret < 0) { dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); -- 1.8.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3] simplefb: print some info about the registered fb 2013-09-07 14:08 ` [PATCH v3] " Tom Gundersen @ 2013-10-01 16:45 ` Tom Gundersen 2013-10-09 9:05 ` Tomi Valkeinen 1 sibling, 0 replies; 9+ messages in thread From: Tom Gundersen @ 2013-10-01 16:45 UTC (permalink / raw) To: linux-fbdev@vger.kernel.org Cc: LKML, tomi.valkeinen, plagnioj, Tom Gundersen, David Herrmann On Sat, Sep 7, 2013 at 4:08 PM, Tom Gundersen <teg@jklm.no> wrote: > This is similar to the output printed by efifb. > > Signed-off-by: Tom Gundersen <teg@jklm.no> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > Cc: David Herrmann <dh.herrmann@gmail.com> > --- > v2: also print smem_len, as requested by David > v3: don't cast, as requested by Geert Jean-Christophe and Tomi, What's the status of this, did either of you pick it up for 3.12 or 3.13? Cheers, Tom ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] simplefb: print some info about the registered fb 2013-09-07 14:08 ` [PATCH v3] " Tom Gundersen 2013-10-01 16:45 ` Tom Gundersen @ 2013-10-09 9:05 ` Tomi Valkeinen 1 sibling, 0 replies; 9+ messages in thread From: Tomi Valkeinen @ 2013-10-09 9:05 UTC (permalink / raw) To: Tom Gundersen; +Cc: linux-fbdev, linux-kernel, plagnioj, David Herrmann [-- Attachment #1: Type: text/plain, Size: 1287 bytes --] On 07/09/13 17:08, Tom Gundersen wrote: > This is similar to the output printed by efifb. > > Signed-off-by: Tom Gundersen <teg@jklm.no> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > Cc: David Herrmann <dh.herrmann@gmail.com> > --- > v2: also print smem_len, as requested by David > v3: don't cast, as requested by Geert > > drivers/video/simplefb.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c > index a29f1c4..50cbceb 100644 > --- a/drivers/video/simplefb.c > +++ b/drivers/video/simplefb.c > @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev) > } > info->pseudo_palette = (void *)(info + 1); > > + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n", > + info->fix.smem_start, info->fix.smem_len, > + info->screen_base); > + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n", > + params.format->name, > + info->var.xres, info->var.yres, > + info->var.bits_per_pixel, info->fix.line_length); > + > ret = register_framebuffer(info); > if (ret < 0) { > dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret); > Thanks, queued for 3.13. Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 901 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-09 9:06 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-06 11:44 [PATCH] simplefb: print some info about the registered fb Tom Gundersen 2013-09-06 11:49 ` Tom Gundersen 2013-09-06 19:11 ` Stephen Warren 2013-09-07 11:16 ` David Herrmann 2013-09-07 11:43 ` [PATCH v2] " Tom Gundersen 2013-09-07 13:55 ` Geert Uytterhoeven 2013-09-07 14:08 ` [PATCH v3] " Tom Gundersen 2013-10-01 16:45 ` Tom Gundersen 2013-10-09 9:05 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox