From: Stephen Warren <swarren@wwwdotorg.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Tomasz Figa <t.figa@samsung.com>,
Dave Martin <Dave.Martin@arm.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Kevin Hilman <khilman@linaro.org>,
gnurou@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/5] ARM: add basic Trusted Foundations support
Date: Fri, 06 Sep 2013 13:29:31 -0600 [thread overview]
Message-ID: <522A2D1B.3010508@wwwdotorg.org> (raw)
In-Reply-To: <1378351680-14696-2-git-send-email-acourbot@nvidia.com>
On 09/04/2013 09:27 PM, Alexandre Courbot wrote:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using a consistent SMC-based API on all supported
> platforms. This patch adds initial basic support for Trusted
> Foundations using the ARM firmware API. Current features are limited
> to the ability to boot secondary processors.
> diff --git a/arch/arm/firmware/trusted_foundations.c b/arch/arm/firmware/trusted_foundations.c
...
> +void of_register_trusted_foundations(void)
> +{
> + struct device_node *node;
> + struct trusted_foundations_platform_data pdata;
> + int err;
> +
> + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
> +
> + if (!node)
> + return;
If you're going to revise this patch for the comment below, then I would
suggest removing the blank line before that if statement.
> diff --git a/arch/arm/include/asm/trusted_foundations.h b/arch/arm/include/asm/trusted_foundations.h
Do we need to add the following here:
#if !IS_ENABLED(CONFIG_OF)
static inline void register_trusted_foundations(...) {}
#endif
So that there is a dummy no-op function for the non-DT-support case? I
guess Tegra always has CONFIG_OF enabled so that call from
mach-tegra/common.c in patch 2 will never be an issue, but perhaps it
might if anyone else uses this?
next prev parent reply other threads:[~2013-09-06 19:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 3:27 [PATCH v5 0/5] ARM: support for Trusted Foundations secure monitor Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 1/5] ARM: add basic Trusted Foundations support Alexandre Courbot
2013-09-05 18:35 ` Rob Herring
2013-09-09 6:15 ` Alexandre Courbot
2013-09-10 13:04 ` Will Deacon
2013-09-12 9:18 ` Linus Walleij
2013-09-12 9:56 ` Alexandre Courbot
2013-09-10 13:18 ` Catalin Marinas
2013-09-06 16:48 ` Linus Walleij
2013-09-09 6:32 ` Alexandre Courbot
2013-09-06 19:29 ` Stephen Warren [this message]
2013-09-09 6:38 ` Alexandre Courbot
2013-09-09 15:59 ` Stephen Warren
2013-09-12 10:00 ` Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 2/5] ARM: tegra: add support for Trusted Foundations Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 4/5] ARM: tegra: set CPU reset handler with firmware op Alexandre Courbot
2013-09-05 3:28 ` [PATCH v5 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522A2D1B.3010508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Dave.Martin@arm.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox